Skip to content

feat(agent): eviction enhancement#934

Merged
luomingmeng merged 2 commits intokubewharf:mainfrom
funnydreamwinz:dev/evict-enhance
Dec 26, 2025
Merged

feat(agent): eviction enhancement#934
luomingmeng merged 2 commits intokubewharf:mainfrom
funnydreamwinz:dev/evict-enhance

Conversation

@funnydreamwinz
Copy link
Copy Markdown
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 57.27483% with 185 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.41%. Comparing base (8892043) to head (62f5d0c).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
.../evictionmanager/plugin/resource/zone_resources.go 11.62% 72 Missing and 4 partials ⚠️
...agent/evictionmanager/plugin/resource/resources.go 73.07% 21 Missing and 14 partials ⚠️
pkg/agent/evictionmanager/podnotifier/notifier.go 65.65% 23 Missing and 11 partials ⚠️
pkg/agent/evictionmanager/manager.go 38.23% 19 Missing and 2 partials ⚠️
...g/agent/evictionmanager/podnotifier/podnotifier.go 78.57% 3 Missing and 3 partials ⚠️
pkg/util/native/pods.go 54.54% 3 Missing and 2 partials ⚠️
...talyst-agent/app/options/eviction/eviction_base.go 50.00% 2 Missing ⚠️
...g/agent/evictionmanager/eviction_resp_collector.go 91.30% 1 Missing and 1 partial ⚠️
...anager/plugin/resource/reclaimed_numa_resources.go 50.00% 1 Missing and 1 partial ⚠️
...tionmanager/plugin/resource/reclaimed_resources.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   60.45%   60.41%   -0.04%     
==========================================
  Files         695      697       +2     
  Lines       65769    66193     +424     
==========================================
+ Hits        39760    39990     +230     
- Misses      21501    21665     +164     
- Partials     4508     4538      +30     
Flag Coverage Δ
unittest 60.41% <57.27%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@funnydreamwinz funnydreamwinz force-pushed the dev/evict-enhance branch 7 times, most recently from 7e28cbe to b2f504d Compare August 20, 2025 12:31
@funnydreamwinz funnydreamwinz added the workflow/need-review review: test succeeded, need to review label Aug 20, 2025
@funnydreamwinz funnydreamwinz removed the workflow/need-review review: test succeeded, need to review label Oct 16, 2025
@funnydreamwinz funnydreamwinz force-pushed the dev/evict-enhance branch 5 times, most recently from b9c257a to c6b4632 Compare November 6, 2025 07:15
@funnydreamwinz funnydreamwinz added the workflow/need-review review: test succeeded, need to review label Nov 26, 2025
Comment thread pkg/agent/evictionmanager/plugin/resource/resources.go Outdated
Comment thread pkg/agent/evictionmanager/plugin/resource/resources.go
Comment thread pkg/agent/evictionmanager/plugin/resource/resources.go Outdated
Comment thread pkg/agent/evictionmanager/plugin/resource/resources.go Outdated
Comment thread pkg/agent/evictionmanager/plugin/resource/resources_test.go Outdated
Comment thread pkg/agent/evictionmanager/podnotifier/podnotifier.go Outdated
Comment thread pkg/agent/evictionmanager/podnotifier/notifier.go Outdated
Comment thread pkg/agent/evictionmanager/podnotifier/notifier.go
Comment thread pkg/agent/evictionmanager/podnotifier/notifier.go Outdated
Comment thread pkg/agent/evictionmanager/podnotifier/notifier.go
@funnydreamwinz funnydreamwinz force-pushed the dev/evict-enhance branch 2 times, most recently from 805b3ce to d84c603 Compare December 10, 2025 07:51
Comment thread pkg/agent/evictionmanager/plugin/resource/resources.go Outdated
Comment thread pkg/agent/evictionmanager/plugin/resource/resources.go
@funnydreamwinz funnydreamwinz force-pushed the dev/evict-enhance branch 3 times, most recently from 00e517b to a975e2a Compare December 15, 2025 12:23
Comment thread pkg/agent/evictionmanager/plugin/resource/zone_resources.go Outdated
Comment thread pkg/agent/evictionmanager/plugin/resource/zone_resources.go Outdated
@funnydreamwinz funnydreamwinz force-pushed the dev/evict-enhance branch 2 times, most recently from a0020ad to a7e6297 Compare December 18, 2025 06:26
@JulyWindK
Copy link
Copy Markdown
Collaborator

LGTM!

Comment thread pkg/agent/evictionmanager/plugin/resource/zone_resources.go Outdated
Comment thread pkg/agent/evictionmanager/plugin/resource/zone_resources.go Outdated
Comment thread pkg/agent/evictionmanager/plugin/resource/zone_resources.go
Comment thread pkg/agent/evictionmanager/plugin/resource/resources.go
@funnydreamwinz funnydreamwinz force-pushed the dev/evict-enhance branch 6 times, most recently from d00ca4e to dcae288 Compare December 26, 2025 07:45
@luomingmeng luomingmeng merged commit b91d521 into kubewharf:main Dec 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflow/need-review review: test succeeded, need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants