feat(advisor): support numa reclaim reserve#964
Merged
xu282934741 merged 1 commit intokubewharf:mainfrom Nov 12, 2025
Merged
Conversation
lihonghao314
requested review from
cheney-lin,
luomingmeng,
sun-yuliang,
waynepeking348 and
xu282934741
as code owners
lihonghao314
force-pushed
the
dev/be-reserve
branch
8 times, most recently
from
4430ba2 to
3965514
Compare
lihonghao314
force-pushed
the
dev/be-reserve
branch
3 times, most recently
from
8f9e69d to
8f543cc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #964 +/- ##
=======================================
Coverage 59.76% 59.77%
=======================================
Files 682 683 +1
Lines 64020 64088 +68
=======================================
+ Hits 38264 38309 +45
- Misses 21357 21376 +19
- Partials 4399 4403 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lihonghao314
force-pushed
the
dev/be-reserve
branch
from
8f543cc to
185c42c
Compare
junyu-peng
reviewed
Nov 11, 2025
| MinIgnoredReclaimedResourceForReport general.ResourceList | ||
| ReservedResourceForAllocate general.ResourceList | ||
| ReservedResourceForReclaimedCores general.ResourceList | ||
| NumaReclaimedResourceRatioForAllocate general.ResourceList |
Collaborator
There was a problem hiding this comment.
could add "Min" in this option name? to keep the same as katalyst-api
| "reserved reclaimed resource actually not allocate to reclaimed resource") | ||
| fs.Var(&o.ReservedResourceForReclaimedCores, "reserved-resource-for-reclaimed-cores", | ||
| "reserved resources for reclaimed_cores pods") | ||
| fs.Var(&o.NumaReclaimedResourceRatioForAllocate, "numa-reserved-resource-ratio-for-reclaimed-cores", |
Collaborator
There was a problem hiding this comment.
these two flag shouldn't have same desc
lihonghao314
force-pushed
the
dev/be-reserve
branch
7 times, most recently
from
f717197 to
de9d9c4
Compare
lihonghao314
commented
Nov 12, 2025
| // StrategyNameMetricThreshold is the name of metric threshold, | ||
| // it offers metric threshold from trombe | ||
| StrategyNameMetricThreshold = "metric_threshold" | ||
|
|
JulyWindK
reviewed
Nov 12, 2025
| ) | ||
|
|
||
| replace ( | ||
| github.com/kubewharf/katalyst-api => github.com/lihonghao314/katalyst-api v0.0.0-20251111070221-3f8cdb7025c9 |
lihonghao314
force-pushed
the
dev/be-reserve
branch
from
de9d9c4 to
39f582e
Compare
lihonghao314
force-pushed
the
dev/be-reserve
branch
from
39f582e to
f82de4e
Compare
JulyWindK
approved these changes
Nov 12, 2025
xu282934741
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
Previously, offline reserved resources configured fixedly at the node level may lead to excessive or insufficient reserved resources at the NUMA level. Therefore, configuring reserved resources at the NUMA dimension is supported, and proportional configuration based on NUMA size is adopted instead of fixed values.