support l3cache package align#988
Merged
xu282934741 merged 6 commits intokubewharf:mainfrom Nov 12, 2025
Merged
Conversation
luomingmeng
requested review from
waynepeking348 and
xu282934741
as code owners
luomingmeng
force-pushed
the
dev/support-l3cache-package-align
branch
from
acfe811 to
210cd8f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #988 +/- ##
==========================================
+ Coverage 59.79% 59.81% +0.01%
==========================================
Files 683 687 +4
Lines 64088 64557 +469
==========================================
+ Hits 38321 38612 +291
- Misses 21365 21503 +138
- Partials 4402 4442 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
luomingmeng
force-pushed
the
dev/support-l3cache-package-align
branch
9 times, most recently
from
afad51e to
391e54b
Compare
luomingmeng
force-pushed
the
dev/support-l3cache-package-align
branch
4 times, most recently
from
b291c8d to
7bc7e9e
Compare
luomingmeng
added
the
workflow/need-review
Implement a new hint optimizer that considers resource package allocations when providing topology hints. The optimizer filters NUMA nodes based on available resources in the specified package, ensuring pods only get hints for nodes with sufficient capacity.
…ache alignment Add L3 cache topology awareness to CPU allocation strategy to improve cache locality. The new algorithm: 1. Adds L3 cache topology information to CPUDetails 2. Implements L3 cache-aware sorting and allocation logic 3. Makes L3 cache alignment optional via parameter 4. Improves error messages and logging for debugging
The assignment of cpuDetails was missing in the tryAlignL3Caches method, which could lead to incorrect CPU allocation. Also added a test case to verify L3 cache alignment behavior.
…tion reuse - Introduce BlockInfo struct to track owner pool and entry details - Split block allocation logic for dedicated and shared/reclaimed pools - Reuse existing allocations for dedicated cores when possible - Improve NUMA-aware CPU allocation strategy
…ontainers block Modify policy advisor to consider both isolation and NUMA-bound share pools when checking for NUMA binding
luomingmeng
force-pushed
the
dev/support-l3cache-package-align
branch
from
ddf8539 to
1cb56e1
Compare
xu282934741
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: