New feature added, legacy closurecompiler.js changed with webpack #129
+4,062
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebpack, reconfigure package.json
… if it's closed or viewed, you can also set dayHidden and dayReminder -1 for that purpose but it was causing errors in ios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my company we are using this package, but we want to force people viewing banner. I have set dayHidden, daysReminder to -1 which work for android but not for ios, so i added new parameter called showAnyWay to control this behaviour. Also when click to view it was directing user to website of google play i changed this to directing user to google play app. I also changed closurecompiler.js with webpack since npm install command didn't even worked because package is not available in repository.