chore: upgrade k8s lib and controller-runtime #634
Conversation
davidebianchi
force-pushed
the
upgrade-controller-runtime
branch
2 times, most recently
from
c87ffb8 to
9bf80a9
Compare
There was a problem hiding this comment.
Thanks for the bumps @davidebianchi !
I just merged a massive refactoring, and there are another couple of changes in flight that touch go.mod so perhaps it's best if I clone your PR (with correct attribution) after I'm done with them?
I certainly want to bump the deps before making a release sometime this or next week.
Signed-off-by: Davide Bianchi <[email protected]>
Signed-off-by: Davide Bianchi <[email protected]>
davidebianchi
force-pushed
the
upgrade-controller-runtime
branch
5 times, most recently
from
2e4052a to
439cf68
Compare
Signed-off-by: Davide Bianchi <[email protected]>
davidebianchi
force-pushed
the
upgrade-controller-runtime
branch
from
439cf68 to
eb85542
Compare
| + updatedReplicas: 1 | ||
| `, result) | ||
| + updatedReplicas: 1`, strings.TrimSpace(result)) |
There was a problem hiding this comment.
Hm, was this necessary for some reason? The trailing newlines are not pretty, but I'd prefer to keep the old version of the test so we don't overlook changes which break the spacing even more.
There was a problem hiding this comment.
It is needed both a newline and a space, and the space in some ide is auto trimmed by default. But got it, I'll restore it
davidebianchi
force-pushed
the
upgrade-controller-runtime
branch
from
43e76f8 to
7d15d9c
Compare
Co-authored-by: Marcin Owsiany <[email protected]> Signed-off-by: Davide Bianchi <[email protected]>
Signed-off-by: Davide Bianchi <[email protected]>
davidebianchi
force-pushed
the
upgrade-controller-runtime
branch
from
7d15d9c to
14fd650
Compare
2 participants
What this PR does / why we need it:
Upgrade go version to 1.24, controller-runtime to 0.22 and kubernetes libs to 0.34