chore(Chart): chartsのsmarthr-uiの依存先をworkspaceに変更#6262
Open
schktjm wants to merge 1 commit into
Open
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
関連URL
なし
概要
packages/chartsが依存するsmarthr-uiを、npm registry からではなく pnpm workspace 内のpackages/smarthr-uiを参照するように変更します。これにより、charts の開発時に常に最新の smarthr-ui を使用でき、バージョンの乖離(従来は npm registry の v74.2.0 を参照していた)を解消します。
変更内容
packages/charts/package.jsonを以下のように変更しました:peerDependenciesのsmarthr-uiを"^74.0.0"→"workspace:^"に変更^91.0.0)に変換されますdevDependenciesに"smarthr-ui": "workspace:*"を追加sandbox/nextパッケージで既にworkspace:*による参照が使われており、同じ方式に統一しています。プロダクト側で対応が必要な事項
publish 時に
peerDependenciesのsmarthr-uiが^91.0.0に変換されるため、charts の次回リリース以降はsmarthr-uiv91 以上が必要になります。確認方法
pnpm install→pnpm ui build→pnpm charts buildでビルドが成功することを確認pnpm charts lintで lint が通ることを確認pnpm charts test -- --runでテストが通ることを確認cd packages/charts && pnpm packで publish 時の package.json を確認し、peerDependencies.smarthr-uiが^91.0.0に変換されていることを確認済み