refactor: best-practice-for-consecutive-definition-listをセレクター方式に書き換え#1321
Merged
Conversation
AtsushiM
requested review from
diescake and
taconasu
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
best-practice-for-consecutive-definition-listルールをセレクター方式に書き換えてコードを簡潔化しました。
変更内容
getPreviousSibling関数によるAST走査ロジックを削除セレクターパターン
A + BA + JSXText[value=/^\s*$/] + BA + JSXExpressionContainer[expression.type="JSXEmptyExpression"] + B4-6. 上記の組み合わせ
コード削減
利点
Test plan
🤖 Generated with Claude Code