Fix ReDoS: bump addressable 2.8.9→2.9.0 - #72
Closed
kulesh wants to merge 1 commit into
Closed
Conversation
Fixes ReDoS vulnerability in Addressable::Template#match, including incomplete remediation from 2.8.10. Improves from O(n^2) to O(n). Supersedes #65 (Dependabot PR). https://claude.ai/code/session_01CDVXuEGetaSKyDrq7p6yrk
|
This pull request has been marked stale due to inactivity. Please update it if you want it to stay open. |
|
Closing due to inactivity. Reopen with an update if still relevant. |
Owner
Author
|
No longer needed — Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue (Required)
Closes #71
Problem and User Value (Required)
addressable2.8.9 has a ReDoS vulnerability inAddressable::Template#match. Version 2.8.10 attempted a fix but the remediation was incomplete. Version 2.9.0 fully resolves it by improving the algorithm from O(n^2) to O(n).This is the last of the 3 high-severity vulnerabilities flagged by GitHub on the default branch (the other two —
mcpCVE-2026-33946 andjsonCVE-2026-33210 — were fixed in #66).Solution Summary (Required)
Update
Gemfile.lock:addressable2.8.9 → 2.9.0. Thejson-schemagem requiresaddressable ~> 2.8(i.e.>= 2.8.0, < 3.0), so 2.9.0 is compatible. No other changes needed.Supersedes Dependabot PR #65.
Verification (Required)
Lockfile-only change. CI will validate:
bundler-audit— should now pass (no remaining advisories)Ruby test and lint— no code changesClass-1 Readiness— no code changesScope Declaration (Required)
This PR only updates
addressableinGemfile.lockto resolve the ReDoS vulnerability described in #71. No other changes.Contributor Acknowledgements (Required)
CONTRIBUTING.md.CODE_OF_CONDUCT.md.