chore(deps): remove dotenv #3768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Cowen <[email protected]>
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
FYI: This will hang around for a while, and depending on workload/priorities might get closed to be reopened at a much later date. |
Contributor
Author
|
Closing this will come back at some point to finish this up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this up in draft while I verify this is fine.
Removes top-level dependency (actually surprisingly removes the dependency entirely 🎉 , I thought vite would use this but apparently not) and removes a weirdly named
VITE_var which is only used in Cypress notVITE_Probably related to #2431 and our overall work to remove unnecessary environment variables that should either be i18n strings, or something else. In this case the something else is "actual bash env var falling back to hardcoded", rather than "actual bash env var falling back to
.envfile var" (loss of locality).There'd maybe a case for keeping this if we had a tonne of env vars that we used everywhere, or if we needed to switch locally often - neither of which we need.