chore(x/x-layout): use XLayout::variant everywhere remove XLayout::type#4631
chore(x/x-layout): use XLayout::variant everywhere remove XLayout::type#4631johncowen wants to merge 5 commits intokumahq:masterfrom
Conversation
Signed-off-by: John Cowen <john.cowen@konghq.com> Assisted-by: OpenCode (Claude Sonnet 4.5)
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: John Cowen <john.cowen@konghq.com>
| |------------------|---------------------|-------| | ||
| | `"stack"` | `"y-stack"` | Vertical stack (renamed for clarity) | | ||
| | `"separated"` | `"separated"` | Direct mapping (no change) | | ||
| | `"columns"` | `"columns"` | Direct mapping (no change, not currently used) | |
There was a problem hiding this comment.
If this not currently used is the reason why it didn't upgrade the places where we use type="columns" then its a lie 😆 I added a commit doing the upgrade for columns
Signed-off-by: John Cowen <john.cowen@konghq.com>
Signed-off-by: John Cowen <john.cowen@konghq.com>
| </template> | ||
|
|
||
| <XLayout | ||
| variant="y-stack" |
There was a problem hiding this comment.
I had to add this here as we no longer have a default/empty variant, pretty sure this is fine
There was a problem hiding this comment.
Is there a specific reason to not have a default variant? Personally I think it's good to not have a default because it's more explicit and easier to follow when reading through the templates how the UI will look like in the end without constantly needing to remember what the default is. Just curious if you had something else in mind 🙂
There was a problem hiding this comment.
Exactly the same reason 🙌 , tbh I'm torn between ease of use and this reasoning you've given here, but as this is a visual thing its nice to have that visual cue in the code.
Signed-off-by: John Cowen <john.cowen@konghq.com>
2 participants
AI refactor (OpenCode/Copilot's Sonnet 4.5) to move XLayout to use
varianteverywhere instead oftype.Temporarily included my prompt/plan, will probably delete that before merge/approval
This PR is also a part experiment/bounce-around of AI. (also see #4623)