chore: stop using kongponents#5042
Conversation
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ed30a1a to
886b2dc
Compare
schogges
left a comment
schogges
left a comment
There was a problem hiding this comment.
LGTM
I suppose we are aiming to remove @kong/kongponents from the kuma-gui manifest. Which requires to have some more exports from x that are currently being imported from @kong/kongponents.
|
Oh sorry I forgot to mention, from what I remember this dramtically reduces our bundle size because we no longer globally
If I understood right I think this might be a reference to the couple of kongponents imports that are left in kuma-gui. In which case the answer is yes. Ideally these would also come from I think the only thing holding me back here is simply choosing a good name for one of the things that are left and then moving the ones that are left (I guess we'll have My main thing here was the reduction in bundle size though, I can circle back soon to remove these last few references and then remove from the kuma-gui manifest entirely. |
Signed-off-by: John Cowen <john.cowen@konghq.com>
Signed-off-by: John Cowen <john.cowen@konghq.com>
886b2dc to
0bafdf3
Compare
|
FYI: I rebased and added a commit to sort out eslint so it tells us if we try and use a kongponent globally, will need another approval 😬 |
|
I also did some checking here on bundle reduction size: savings of 100kb gzipped and the parsing etc of that 🎉 |
Similar to #5042, we use @kumahq/x now instead and have done for quite a while. Note: I plan on adding https://stylelint.io/user-guide/rules/no-unknown-custom-properties/ very soon as a follow up. --------- Signed-off-by: John Cowen <john.cowen@konghq.com>
2 participants
Stop using kongponents i.e. don't install them globally anymore
We use
@kumahq/xnow instead and have done for quite a while.I also did some checking here on bundle reduction size:
savings of 100kb gzipped and the parsing etc of that 🎉