Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mads/hds): remove custom cache implementation #11590

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Sep 27, 2024

In mads and hds we were using a custom implementation of a cache. This was unfortunate as go-control-plane has a perfectly working one.

The only feature on this cache was the ability to long poll. This was only required in mads and we've changed the handler of mads to make this handling outside of the cache.

This is more complete fix to problems like: #11578 as there is now only one reconciling loop.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lahabana lahabana added this to the 2.10.x milestone Sep 27, 2024
In mads and hds we were using a custom implementation of a cache.
This was unfortunate as go-control-plane has a perfectly working one.

The only feature on this cache was the ability to long poll.
This was only required in mads and we've changed the handler of mads
to make this handling outside of the cache.

Signed-off-by: Charly Molter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant