Skip to content

fix(core): reconcile completed Team Project edges - #1556

Merged
kunickiaj merged 1 commit into
mainfrom
ajk--fix_core_reconcile_completed_team_project_edges
Sep 1, 2026
Merged

fix(core): reconcile completed Team Project edges#1556
kunickiaj merged 1 commit into
mainfrom
ajk--fix_core_reconcile_completed_team_project_edges

Conversation

@kunickiaj

@kunickiaj kunickiaj commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Description

Additively restores missing setup-owned Team→Project recipient edges for older compatible completions. Reconciliation runs under the existing immediate transaction, preserves user-owned and independent Team edges byte-for-byte, rejects malformed or cross-boundary state before writing, and rolls back if strict post-write readiness does not hold.

Tracks codemem-752i.6.

Type of Change

  • 🚀 Feature (new functionality)
  • 🐛 Bug fix (fixes an issue)
  • 📚 Documentation (docs-only change)
  • 🔧 Maintenance (refactor, chore, CI, etc.)
  • 🧪 Testing (test-only changes)

Testing

  • 112 focused candidate and activation tests
  • Insert, replay, setup-owned reactivation, user-owned preservation, malformed sibling, independent Team, and rollback coverage
  • pnpm run tsc
  • pnpm run lint

Checklist

  • Code follows project style
  • Security/data-integrity CodeReviewer approval
  • No new warnings introduced

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T15:57:34.574818Z 2fba0c0 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ab0857031

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/core/src/legacy-team-candidate.ts
@kunickiaj
kunickiaj force-pushed the ajk--feat_ui_prioritize_actionable_team_setup_work branch from 01de5a6 to f348ea3 Compare August 31, 2026 20:23
@kunickiaj
kunickiaj force-pushed the ajk--fix_core_reconcile_completed_team_project_edges branch from 3ab0857 to 179dcf1 Compare August 31, 2026 20:23
@kunickiaj
kunickiaj changed the base branch from ajk--feat_ui_prioritize_actionable_team_setup_work to graphite-base/1556 August 31, 2026 21:02
@kunickiaj
kunickiaj force-pushed the ajk--fix_core_reconcile_completed_team_project_edges branch from 179dcf1 to 2dfe580 Compare August 31, 2026 21:02
@kunickiaj
kunickiaj changed the base branch from graphite-base/1556 to ajk--feat_ui_prioritize_actionable_team_setup_work August 31, 2026 21:02
@kunickiaj
kunickiaj changed the base branch from ajk--feat_ui_prioritize_actionable_team_setup_work to graphite-base/1556 August 31, 2026 21:40
@kunickiaj
kunickiaj force-pushed the ajk--fix_core_reconcile_completed_team_project_edges branch from 2dfe580 to 29d657d Compare August 31, 2026 21:41
@kunickiaj
kunickiaj changed the base branch from graphite-base/1556 to ajk--feat_ui_prioritize_actionable_team_setup_work August 31, 2026 21:41
@kunickiaj
kunickiaj changed the base branch from ajk--feat_ui_prioritize_actionable_team_setup_work to graphite-base/1556 August 31, 2026 22:16
@kunickiaj
kunickiaj force-pushed the ajk--fix_core_reconcile_completed_team_project_edges branch from 29d657d to c65425d Compare September 1, 2026 01:10
@kunickiaj
kunickiaj changed the base branch from graphite-base/1556 to ajk--feat_ui_prioritize_actionable_team_setup_work September 1, 2026 01:11
@kunickiaj
kunickiaj force-pushed the ajk--fix_core_reconcile_completed_team_project_edges branch from c65425d to fa244c2 Compare September 1, 2026 01:39
@kunickiaj
kunickiaj force-pushed the ajk--feat_ui_prioritize_actionable_team_setup_work branch 2 times, most recently from 3fd4977 to e1d4300 Compare September 1, 2026 02:27
@kunickiaj
kunickiaj force-pushed the ajk--fix_core_reconcile_completed_team_project_edges branch 2 times, most recently from 20513da to c070c0e Compare September 1, 2026 05:38
@kunickiaj
kunickiaj force-pushed the ajk--feat_ui_prioritize_actionable_team_setup_work branch from e1d4300 to 845f00c Compare September 1, 2026 05:38

kunickiaj commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

Merge activity

  • Sep 1, 3:44 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 1, 3:55 PM UTC: Graphite rebased this pull request as part of a merge.
  • Sep 1, 4:00 PM UTC: @kunickiaj merged this pull request with Graphite.

@kunickiaj
kunickiaj changed the base branch from ajk--feat_ui_prioritize_actionable_team_setup_work to graphite-base/1556 September 1, 2026 15:45
@kunickiaj
kunickiaj changed the base branch from graphite-base/1556 to main September 1, 2026 15:53
@kunickiaj
kunickiaj force-pushed the ajk--fix_core_reconcile_completed_team_project_edges branch from c070c0e to 2fba0c0 Compare September 1, 2026 15:54
@kunickiaj
kunickiaj merged commit c60a708 into main Sep 1, 2026
14 checks passed
@kunickiaj
kunickiaj deleted the ajk--fix_core_reconcile_completed_team_project_edges branch September 1, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant