fix(tools): defer var/run creation until after pivot - #221
Open
ethe wants to merge 1 commit into
Open
Conversation
Contributor
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 4 selected item(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #202
Summary
/mnt/user/var/runbeforepivot_root/mnt/user/runpreparation and letpivot-initcreate/var/runafter the root switchmake test-unitand cover both init scripts in the CI path filtersWhy
Some distribution images, including Ubuntu, provide
/var/runas an absolute symlink to/run. Beforepivot_root, following that symlink resolves against the tools-drive root instead of the mounted user root and produces the deterministic bootstrap warning reported in #202.pivot-initalready creates and mounts/run, then prepares/var/runafter the root switch. Deferring this redundant directory preparation therefore fixes absolute-symlink resolution without distro detection or image-specific behavior.Validation
bash scripts/tests/verify-tools-init.shshellcheck tools-image/init tools-image/pivot-init scripts/tests/verify-tools-init.shactionlint .github/workflows/ci.ymlgit diff --checkRelease note
This updates the tools-image source. After merge, a new immutable
ghcr.io/kvcache-ai/agentenv-toolsversion still needs to be published and selected inconfig/deps_manifest.toml; the existing0.1.0artifact will not contain the change.