fix: avoid Tauri resource aborts in Auto Suggest#1496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Summary
Fixes Auto Suggest triggering Tauri HTTP resource errors such as
The resource id ... is invalid.Auto Suggest used an
AbortControllerto cancel in-flight suggestion requests when chat state changed, the chat page changed, or suggestions were re-rolled. On Tauri desktop, that abort signal is passed into@tauri-apps/plugin-http, where aborting around response body reads can race with native resource cleanup and surface an invalid resource id error.Related Issues
Fixes #1443.
Changes
src/lib/ChatScreens/Suggestion.sveltedoingChat.set(true); doingChat.set(false)to re-roll suggestionssrc/ts/globalApi.svelte.tsImpact
Additional Notes
Validated with:
pnpm checkpnpm testpnpm buildgit diff --checkonly reported existing CRLF conversion warnings.Footnotes
Modifies the behavior of prompting, requesting, or handling responses from AI models. ↩
Over 80% of the code is AI generated. ↩