fix: improve hotkey settings layout#1498
Open
cubicj wants to merge 1 commit into
Open
Conversation
Contributor
|
Nice work! Would it be possible to show Command (⌘) for Ctrl and Option (⌥) for Alt on macOS? |
Collaborator
Author
Good idea. I think this should be handled in a separate PR because showing Command for Ctrl also needs matching macOS metaKey behavior, not just a label change. I'll keep this PR scoped to the Hotkey Settings layout fix and follow up separately. |
10 tasks
sub-hub
approved these changes
Jul 5, 2026
sub-hub
left a comment
Collaborator
There was a problem hiding this comment.
It looks like there are no errors. Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Summary
Fixes the Hotkey Settings page rendering as an empty settings panel on narrow widths.
The settings shell only rendered
HotkeySettingswhenwindow.innerWidth >= 768, while the page itself also had a separate small-screen fallback. This made the selected Hotkey tab show no usable content at narrower widths.This PR removes that width gate and updates the Hotkey Settings layout so it remains readable on both narrow and wider settings views.
Related Issues
None.
Changes
src/lib/Setting/Settings.svelteHotkeySettingswhen the Hotkey settings menu is selectedwindow.innerWidth >= 768condition that could leave the content panel emptysrc/lib/Setting/Pages/HotkeySettings.sveltescreenTooSmallbranchAction / HotkeySPACEsrc/lang/ko.tsImpact
Screenshots
Additional Notes
Validated with:
pnpm checkpnpm testpnpm buildgit diff --checkpnpm buildcompleted with existing non-blocking warnings.Footnotes
Modifies the behavior of prompting, requesting, or handling responses from AI models. ↩
Over 80% of the code is AI generated. ↩