Skip to content

fix: improve hotkey settings layout#1498

Open
cubicj wants to merge 1 commit into
mainfrom
cubicj-fix-hotkey-settings-width
Open

fix: improve hotkey settings layout#1498
cubicj wants to merge 1 commit into
mainfrom
cubicj-fix-hotkey-settings-width

Conversation

@cubicj

@cubicj cubicj commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

PR Checklist

  • Required Checks
    • Have you added type definitions?
    • Have you tested your changes?
    • Have you checked that it won't break any existing features?
  • If your PR uses models1, check the following:
    • Have you checked if it works normally in all models?
    • Have you checked if it works normally in all web, local, and node-hosted versions? If it doesn't, have you blocked it in those versions?
  • If your PR is highly AI generated2, check the following:
    • Have you understood what the code does?
    • Have you cleaned up any unnecessary or redundant code?
    • Is it not a huge change?
      • We currently do not accept highly AI generated PRs that are large changes.

Summary

Fixes the Hotkey Settings page rendering as an empty settings panel on narrow widths.

The settings shell only rendered HotkeySettings when window.innerWidth >= 768, while the page itself also had a separate small-screen fallback. This made the selected Hotkey tab show no usable content at narrower widths.

This PR removes that width gate and updates the Hotkey Settings layout so it remains readable on both narrow and wider settings views.

Related Issues

None.

Changes

src/lib/Setting/Settings.svelte

  • Always render HotkeySettings when the Hotkey settings menu is selected
  • Remove the window.innerWidth >= 768 condition that could leave the content panel empty

src/lib/Setting/Pages/HotkeySettings.svelte

  • Remove the small-screen screenTooSmall branch
  • Replace the table layout with a responsive bordered list layout
  • Add a page title to match the other settings pages
  • Add an action / hotkey header row
  • Align the hotkey header with the hotkey control column on wider widths
  • Keep the narrow-width header compact as Action / Hotkey
  • Keep Ctrl, Shift, and Alt toggle buttons visually simple without active borders
  • Format the key input display consistently, including SPACE

src/lang/ko.ts

  • Add missing Korean labels for the Popup Editor and Loadout hotkey actions

Impact

  • The Hotkey Settings page is visible and usable at narrow widths instead of showing an empty panel.
  • Existing hotkey data and hotkey behavior are unchanged.
  • The change is limited to settings-page rendering, layout, and missing Korean display text.
  • No request handling, model behavior, storage format, database schema, or platform-specific logic is changed.

Screenshots

Desktop Narrow width
Hotkey settings desktop layout Hotkey settings narrow width layout

Additional Notes

Validated with:

  • pnpm check
  • pnpm test
  • pnpm build
  • git diff --check

pnpm build completed with existing non-blocking warnings.

Footnotes

  1. Modifies the behavior of prompting, requesting, or handling responses from AI models.

  2. Over 80% of the code is AI generated.

@cubicj cubicj marked this pull request as ready for review June 23, 2026 10:38
@SameDesu123

Copy link
Copy Markdown
Contributor

Nice work! Would it be possible to show Command (⌘) for Ctrl and Option (⌥) for Alt on macOS?

@cubicj

cubicj commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

Nice work! Would it be possible to show Command (⌘) for Ctrl and Option (⌥) for Alt on macOS?

Good idea. I think this should be handled in a separate PR because showing Command for Ctrl also needs matching macOS metaKey behavior, not just a label change.

I'll keep this PR scoped to the Hotkey Settings layout fix and follow up separately.

@cubicj cubicj mentioned this pull request Jun 24, 2026
10 tasks

@sub-hub sub-hub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are no errors. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants