test: replace module handler snapshots with explicit assertions#1499
Open
cubicj wants to merge 1 commit into
Open
test: replace module handler snapshots with explicit assertions#1499cubicj wants to merge 1 commit into
cubicj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Summary
Replaces the module MCP handler snapshot tests with explicit assertions.
The module handler tests were the only tests using Vitest snapshots. On Windows with Git autocrlf, running
pnpm testcould rewrite the snapshot file and leave it marked as modified even when there was no content diff.Related Issues
None.
Changes
src/ts/process/mcp/risuaccess/tests/modules.test.tstoMatchSnapshot()checks with explicittoEqual(makeToolResponse(...))assertionssrc/ts/process/mcp/risuaccess/tests/__snapshots__/modules.test.ts.snapImpact
pnpm testno longer rewrites the module handler snapshot file.Additional Notes
Validated with:
pnpm testgit diff --checkFootnotes
Modifies the behavior of prompting, requesting, or handling responses from AI models. ↩
Over 80% of the code is AI generated. ↩