[Bug] Prevent empty non-interactive tasks from reading stdin - #1855
Open
nightcityblade wants to merge 1 commit into
Open
[Bug] Prevent empty non-interactive tasks from reading stdin#1855nightcityblade wants to merge 1 commit into
nightcityblade wants to merge 1 commit into
Conversation
|
Hello there, thank you for opening an PR ! 🙏🏻 The team was notified and they will get back to you asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Swarms!
run()receivesNone, an empty string, or whitespace. Such calls now raise a clearValueError; interactive agents retain their prompt behavior. Adds focused regression coverage that fails if stdin is accessed.Please make sure your PR is passing linting and testing before submitting. Run
make format,make lintandmake testto check this locally.See contribution guidelines for more information on how to write/run tests, lint, etc:
https://github.com/kyegomez/swarms/blob/master/CONTRIBUTING.md
If you're adding a new integration, please include:
Maintainer responsibilities:
If no one reviews your PR within a few days, feel free to email Kye at kye@swarms.world
See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/kyegomez/swarms
Validation performed:
.venv/bin/python -m pytest tests/structs/test_agent.py::TestBasicAgent::test_noninteractive_empty_task_does_not_read_stdin -q— 3 passed.venv/bin/black . --check --diff— 955 files unchanged.venv/bin/ruff check .— passed