Skip to content

feature: add support for slicing above i32 where u64 can safely be coerced to f64 losslessly #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylebarron merged 7 commits into from
Apr 17, 2026
+48 −16
Merged

feature: add support for slicing above i32 where u64 can safely be coerced to f64 losslessly #861

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fedef7d
feature: add support for slicing above i32 where u64 can safely be co…
mobiusklein Mar 21, 2026
d921288
chore: fmt
mobiusklein Mar 21, 2026
f9baa54
address review comments
mobiusklein Mar 24, 2026
61fa689
chore: fmt
mobiusklein Mar 24, 2026
05c2c0c
chore: clippy
mobiusklein Mar 24, 2026
d4afa80
change: rework error conversion and pipelining
mobiusklein Mar 27, 2026
735e7a6
fix: variant is not always available
mobiusklein Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/reader_async.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,12 +326,24 @@ impl WrappedFile {
let (sender, receiver) = oneshot::channel();
let file = self.inner.clone();
spawn_local(async move {
let subset_blob = file
.slice_with_i32_and_i32(
let subset_blob = if (range.start <= i32::MAX as u64) && (range.end <= i32::MAX as u64)

@kylebarron kylebarron Mar 23, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having two branches for i32 and f64, we can probably first check that the range start and end is representable as an integer in f64, and then only use the f64 slice api

{
file.slice_with_i32_and_i32(
range.start.try_into().unwrap(),
range.end.try_into().unwrap(),
)
.unwrap();
.unwrap()
} else {
let start = range.start as f64;
if start as u64 != range.start {
panic!("Cannot safely convert start index of {range:?}");

@kylebarron kylebarron Mar 23, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of panicking, we should change this method to be fallible and return an Err

}
let end = range.end as f64;
if end as u64 != range.end {
panic!("Cannot safely convert start index of {range:?}");
}
file.slice_with_f64_and_f64(start, end).unwrap()
};
let buf = JsFuture::from(subset_blob.array_buffer()).await.unwrap();
let out_vec = Uint8Array::new_with_byte_offset(&buf, 0).to_vec();
sender.send(out_vec).unwrap();
Expand Down
Loading