Make entity naming and entity_id independent of pet name

[kylegordon]

Summary

• Entity friendly names were built as f"{pet_name} {suffix}" (e.g. "Fluffy Battery Level"). With has_entity_name unset, HA slugged that combined string into the entity_id at first creation — so renaming the pet later left the entity_id permanently stuck on the old name (e.g. sensor.fluffy_battery_level), even though unique_id was already correctly keyed on device.id.
• Sets _attr_has_entity_name = True on all sensor, binary sensor, and device tracker entities, with per-entity suffix names (e.g. "Battery Level", "At Home", "Charging"). HA now composes the displayed friendly name from the device name (still the pet's name, pulled live from device.details.name on every coordinator refresh) + the entity's own name.
• Pins _attr_suggested_object_id to a device.id-based slug (e.g. pettracer_12345_battery_level) so newly created entities get an entity_id that's stable regardless of pet renames.
• The device tracker entity (which represents the pet itself) sets _attr_name = None so its friendly name is exactly the device name, matching prior behavior.
• This only affects newly created entities going forward — existing installs keep their current entity_ids untouched (HA doesn't auto-migrate entity_id, and neither does this change, to avoid silently breaking dashboards/automations that reference the old ids).

Test plan

• Updated tests/test_sensor.py, tests/test_binary_sensor.py, tests/test_device_tracker.py to assert the new name/_attr_suggested_object_id/_attr_has_entity_name values.
• Full suite passes: 74 passed, 98% coverage (pytest --cov=custom_components.pettracer --cov-report=term -v), above the CI 90% gate.
• ruff check clean on the three modified platform files.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Updates PetTracer entities so new entity IDs are based on stable device IDs rather than pet names.

Changes:

• Enables Home Assistant entity-name composition across all platforms.
• Adds device-ID-based suggested object IDs.
• Updates unit tests for naming attributes.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
custom_components/pettracer/sensor.py	Updates sensor naming and suggested IDs.
custom_components/pettracer/binary_sensor.py	Updates binary sensor naming and suggested IDs.
custom_components/pettracer/device_tracker.py	Delegates tracker naming to the device.
tests/test_sensor.py	Updates sensor naming assertions.
tests/test_binary_sensor.py	Updates binary sensor naming assertions.
tests/test_device_tracker.py	Updates tracker naming assertions.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[kylegordon]

Added regression tests in 5abd8c1 (test_sensor_device_info_reflects_pet_rename, test_at_home_binary_sensor_device_info_reflects_pet_rename, test_device_tracker_device_info_reflects_pet_rename) that construct the entity, mutate mock_device.details.name, refresh coordinator.data, and assert device_info["name"]" picks up the new name while unique_id/_attr_suggested_object_id/device_info["identifiers"]stay fixed — this is exactly what caught the constructor-cached device name bug you flagged below. I stopped short of driving this through a fullentity_platform/entity-registry registration (real hass.states/entity_id` assignment), since these tests already unit-test each entity's own attribute computation directly and the existing test suite in this repo deliberately avoids full platform-forwarding setup for speed/isolation. Happy to add a true end-to-end registration test as a follow-up if you'd like that extra coverage.

[kylegordon]

Confirmed and fixed in 5abd8c1 — device_info was reading self._device_name/self._device.sw, both captured once in __init__ and never refreshed. It now calls _get_device_data() (already used by every other property in these classes) to get the latest device on each access, falling back to the constructor-time device if it's momentarily missing from coordinator data. Same bug existed in sensor.py and binary_sensor.py too, so fixed all three.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Suppressed comments (1)

custom_components/pettracer/device_tracker.py:60

• device_info is consumed when Home Assistant registers the entity; it is not re-read on each CoordinatorEntity refresh. Therefore returning the latest device here does not update the device-registry name, so a PetTracer rename still leaves the composed friendly names on the old pet name. Register a coordinator listener that calls the HA device registry's update API for this identifier when the API name changes, and cover the behavior with an entity/device-registry test rather than directly reading this property.

        device = self._get_device_data() or self._device
        device_name = (
            device.details.name if device.details else f"PetTracer {self._device_id}"
        )