Skip to content

Commit 86c6316

Browse files
Lighthouse test correction
1 parent c839524 commit 86c6316

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed

src/shared/components/GenericList/Pagination/Pagination.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ export const Pagination = ({
110110
isInteractable={currentPage !== 1}
111111
onClick={() => onChangePage(1)}
112112
accessibleName="First page"
113-
accesskey="first-page-link"
114113
>
115114
<Icon
116115
accessibleName="first page icon"
@@ -123,7 +122,6 @@ export const Pagination = ({
123122
isInteractable={currentPage !== 1}
124123
onClick={() => onChangePage(currentPage - 1)}
125124
accessibleName="Previous page"
126-
accesskey="previous-page-link"
127125
>
128126
<Icon
129127
accessibleName="previous page icon"
@@ -172,7 +170,6 @@ export const Pagination = ({
172170
isInteractable={currentPage !== pagesCount}
173171
onClick={() => onChangePage(currentPage + 1)}
174172
accessibleName="Next page"
175-
accesskey="next-page-link"
176173
>
177174
<Icon
178175
accessibleName="next page icon"
@@ -185,7 +182,6 @@ export const Pagination = ({
185182
isInteractable={currentPage !== pagesCount}
186183
onClick={() => onChangePage(pagesCount)}
187184
accessibleName="Last page"
188-
accesskey="last-page-link"
189185
>
190186
<Icon
191187
accessibleName="last page icon"

src/shared/components/GenericList/components.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ import {
1515
import ListActions from 'shared/components/ListActions/ListActions';
1616

1717
export const BodyFallback = ({ children }) => (
18-
<TableCell slot="noData" style={{ width: '100%' }}>
18+
<div slot="noData" style={{ width: '100%' }}>
1919
<div className="body-fallback">{children}</div>
20-
</TableCell>
20+
</div>
2121
);
2222

2323
export const HeaderRenderer = ({
@@ -41,7 +41,6 @@ export const HeaderRenderer = ({
4141
importance={0}
4242
popinHidden={true}
4343
key="actions-column"
44-
scope="col"
4544
aria-label="actions-column"
4645
minWidth={`${30 * actions.length}px`}
4746
>
@@ -78,7 +77,6 @@ export const HeaderRenderer = ({
7877
{headerRenderer()?.map((h, index) => {
7978
return (
8079
<TableHeaderCell
81-
scope="col"
8280
key={`${typeof h === 'object' ? index : h}-column`}
8381
popinText={h === 'Popin' ? t('common.headers.specification') : h}
8482
popinHidden={h !== 'Popin' && !noHideFields?.includes(h)}

src/shared/components/PodTemplate/components.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ function PodTemplateTable({ className, items, columns, rowRenderer }) {
2929
headerRow={
3030
<TableHeaderRow style={{ width: '50%' }}>
3131
{columns.map(column => (
32-
<TableHeaderCell scope="col" key={column}>
32+
<TableHeaderCell key={column}>
3333
<Title level="H5">{column}</Title>
3434
</TableHeaderCell>
3535
))}

0 commit comments

Comments
 (0)