chore: Turn on ban-ts-comment eslint rule (#4424)

* chore: turn on ban-ts-comment rule

* fix: improve description in comment

Author: awoloszyn22

eslint.config.ts

@@ -56,7 +56,7 @@ export default defineConfig(
         '@typescript-eslint/no-non-null-asserted-optional-chain': 'warn',
         '@typescript-eslint/no-unsafe-function-type': 'warn',
         '@typescript-eslint/no-unused-expressions': 'warn',
-        '@typescript-eslint/ban-ts-comment': 'warn',
+        '@typescript-eslint/ban-ts-comment': 'error',
         '@typescript-eslint/no-require-imports': 'warn',
         // Misc
         'no-unused-vars': [

src/command-pallette/CommandPalletteUI/handlers/clusterResourceHandler.ts

@@ -136,7 +136,7 @@ function sendNamespaceSwitchMessage(
     );
   if (!matchedRoute) return;
 
-  // @ts-ignore
+  //@ts-expect-error Property is accessible
   const resourceType = matchedRoute.params.resourceType || '';
 
   navigate(
@@ -338,7 +338,7 @@ function createResults(context: CommandPaletteContext): Result[] {
   let resources = resourceCache[resourceType];
 
   if (typeof resources !== 'object') {
-    //@ts-ignore  TODO: handle typein Result
+    //@ts-expect-error TODO: handle type in Result
     return [linkToList, { type: LOADING_INDICATOR }];
   }
   if (resourceType === 'namespaces' && !showHiddenNamespaces) {

src/command-pallette/CommandPalletteUI/handlers/crdHandler.ts

@@ -104,7 +104,7 @@ function createResults(context: CommandPaletteContext): Result[] {
 
   const crds = resourceCache['customresourcedefinitions'];
   if (typeof crds !== 'object') {
-    //@ts-ignore  TODO: handle typein Result
+    //@ts-expect-error TODO: handle typein Result
     return [linkToList, { type: LOADING_INDICATOR }];
   }
 

src/command-pallette/CommandPalletteUI/handlers/helmReleaseHandler.ts

@@ -119,7 +119,7 @@ function createResults(context: CommandPaletteContext): Result[] | null {
   };
 
   if (typeof helmReleases !== 'object') {
-    //@ts-ignore todo: how to handle 'type' in Result[]?
+    //@ts-expect-error Todo: handle 'type' in Result[]
     return [linkToList, { type: LOADING_INDICATOR }];
   }
 

src/command-pallette/CommandPalletteUI/handlers/logsHandler.ts

@@ -108,7 +108,7 @@ function createResults(context: CommandPaletteContext): Result[] {
   const { resourceCache, tokens, namespace } = context;
   const pods = resourceCache[`${namespace}/pods`] as Pod[];
   if (typeof pods !== 'object') {
-    //@ts-ignore  TODO: handle typein Result
+    //@ts-expect-error  TODO: handle type in Result
     return [{ type: LOADING_INDICATOR }];
   }
 

src/components/App/App.tsx

@@ -149,7 +149,7 @@ export default function App() {
               manualKubeConfigId.formOpen &&
               createPortal(
                 <Dialog open={true}>
-                  {/*@ts-ignore*/}
+                  {/*@ts-expect-error Type mismatch between js and ts*/}
                   <ResourceForm.Single
                     formElementRef={authFormRef}
                     createResource={updateManualKubeConfigIdState}
@@ -164,7 +164,7 @@ export default function App() {
                         {t('clusters.add.title')}
                       </Button>
                     </div>
-                    {/*@ts-ignore*/}
+                    {/*@ts-expect-error Type mismatch between js and ts*/}
                   </ResourceForm.Single>
                 </Dialog>,
                 document.body,

src/components/Clusters/views/ClusterOverview/ClusterValidation/ResourceValidation.ts

@@ -19,7 +19,7 @@ const executeInWorker = (...args: any[]) =>
         },
         { once: true },
       );
-      // @ts-ignore
+      // @ts-expect-error args are of type any[], no easy fix
       worker.postMessage(...args);
     });
   });

src/components/Modules/community/components/AddSourceYamls.tsx

@@ -283,7 +283,7 @@ export const AddSourceYamls = () => {
                     return (
                       <OptionCustom
                         // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-                        // @ts-ignore
+                        // @ts-expect-error
                         disabled
                         value={ns}
                         key={ns}

src/components/Preferences/ResourceValidation/ResourceValidationSettings.tsx

@@ -123,7 +123,7 @@ export default function ResourceValidationSettings() {
               title={t(
                 'settings.clusters.resourcesValidation.enabled-policies',
               )}
-              //@ts-ignore
+              //@ts-expect-error Type mismatch between js and ts
               entries={
                 choosePolicies
                   ? policyList

src/resources/ServiceAccounts/TokenRequestModal/TokenRequestModal.tsx

@@ -39,7 +39,7 @@ const ComboboxInputWithSeconds = ({
   generateTokenRequest: () => void;
 }) => {
   return (
-    //@ts-ignore
+    //@ts-expect-error Mismatch between js and ts
     <ComboboxInput
       id="event-version-combobox"
       required
@@ -121,12 +121,12 @@ export function TokenRequestModal({
         />
       }
     >
-      {/*@ts-ignore*/}
+      {/*@ts-expect-error Type mismatch between js and ts*/}
       <ResourceForm.Single
         resource={tokenRequest}
         setResource={setTokenRequest}
       >
-        {/*@ts-ignore*/}
+        {/*@ts-expect-error Type mismatch between js and ts*/}
         <ResourceForm.FormField
           required
           propertyPath="$.spec.expirationSeconds"
@@ -155,7 +155,6 @@ export function TokenRequestModal({
               justifyContent: 'flex-end',
             }}
           >
-            {/*@ts-ignore*/}
             <CopiableText
               iconOnly
               buttonText={t('common.buttons.copy')}
@@ -172,7 +171,7 @@ export function TokenRequestModal({
               {t('service-accounts.headers.download-kubeconfig')}
             </Button>
           </div>
-          {/*@ts-ignore*/}
+          {/*@ts-expect-error Type mismatch between js and ts */}
           <Editor
             value={kubeconfigYaml}
             updateValueOnParentChange
@@ -182,7 +181,7 @@ export function TokenRequestModal({
             language="yaml"
           />
         </div>
-        {/*@ts-ignore*/}
+        {/*@ts-expect-error Type mismatch between js and ts*/}
       </ResourceForm.Single>
     </Dialog>
   );