Skip to content

feat(Modules): Add icon from ModuleTemplates#3550

Merged
mrCherry97 merged 8 commits intokyma-project:mainfrom
mrCherry97:feat-module-icons
Dec 27, 2024
Merged

feat(Modules): Add icon from ModuleTemplates#3550
mrCherry97 merged 8 commits intokyma-project:mainfrom
mrCherry97:feat-module-icons

Conversation

@mrCherry97
Copy link
Contributor

Description

Changes proposed in this pull request:

  • add displaying icons from ModuleTemaplates
  • add checking if the image is available on the link

Related issue(s)
Closes #3465

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2024
@mrCherry97 mrCherry97 marked this pull request as ready for review December 19, 2024 10:59
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 19, 2024
Copy link
Contributor

@OliwiaGowor OliwiaGowor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module card with custom icon is causing the whole column to stretch horizontally when details are opened
Screenshot 2024-12-20 at 09 58 48
Screenshot 2024-12-20 at 09 58 56

OliwiaGowor
OliwiaGowor previously approved these changes Dec 27, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 27, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 27, 2024
@mrCherry97 mrCherry97 added the lgtm Looks good to me! label Dec 27, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 27, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 27, 2024
@mrCherry97 mrCherry97 merged commit 85d02d6 into kyma-project:main Dec 27, 2024
13 checks passed
@mrCherry97 mrCherry97 deleted the feat-module-icons branch December 27, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon in Add Modules view is taken from ModuleTemplate

3 participants