Skip to content

chore: add unsafe eval for accessibility tests#3558

Merged
mrCherry97 merged 2 commits intokyma-project:mainfrom
mrCherry97:fix-acc-tests-3
Jan 14, 2025
Merged

chore: add unsafe eval for accessibility tests#3558
mrCherry97 merged 2 commits intokyma-project:mainfrom
mrCherry97:fix-acc-tests-3

Conversation

@mrCherry97
Copy link
Contributor

Description

Changes proposed in this pull request:

  • chore: add unsafe eval for accessibility tests

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@mrCherry97 mrCherry97 marked this pull request as ready for review December 27, 2024 10:01
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 27, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 27, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 27, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 14, 2025
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mrCherry97 mrCherry97 added the lgtm Looks good to me! label Jan 14, 2025
@mrCherry97
Copy link
Contributor Author

/override tide

@kyma-bot
Copy link
Contributor

@mrCherry97: Overrode contexts on behalf of mrCherry97: tide

Details

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrCherry97 mrCherry97 merged commit 30d2816 into kyma-project:main Jan 14, 2025
6 checks passed
@mrCherry97 mrCherry97 deleted the fix-acc-tests-3 branch January 14, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants