Skip to content

fix: Checking validity of the message for badge description#3569

Merged
mrCherry97 merged 7 commits intokyma-project:mainfrom
KonradPietocha:wrong-badge-description
Jan 10, 2025
Merged

fix: Checking validity of the message for badge description#3569
mrCherry97 merged 7 commits intokyma-project:mainfrom
KonradPietocha:wrong-badge-description

Conversation

@KonradPietocha
Copy link
Contributor

@KonradPietocha KonradPietocha commented Jan 7, 2025

Description

Changes proposed in this pull request:

  • Extract message from description and check validity

Related issue(s)

Closes #3560

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Jan 7, 2025
@OliwiaGowor OliwiaGowor self-assigned this Jan 8, 2025
Copy link
Contributor

@OliwiaGowor OliwiaGowor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work if a correct error message will include 'null' or 'undefined' in it's content? (for example "Error: invalid runtime value: value is undefined")

@KonradPietocha
Copy link
Contributor Author

Corrected

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 10, 2025
@mrCherry97
Copy link
Contributor

/override tide

@kyma-bot
Copy link
Contributor

@mrCherry97: Overrode contexts on behalf of mrCherry97: tide

Details

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrCherry97 mrCherry97 merged commit af14255 into kyma-project:main Jan 10, 2025
13 checks passed
@KonradPietocha KonradPietocha deleted the wrong-badge-description branch January 10, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Badge's description does not handle null values well

4 participants