Skip to content

feat: Information about associated resources in delete modal for modules#3576

Merged
mrCherry97 merged 14 commits intokyma-project:mainfrom
mrCherry97:module-delete
Jan 15, 2025
Merged

feat: Information about associated resources in delete modal for modules#3576
mrCherry97 merged 14 commits intokyma-project:mainfrom
mrCherry97:module-delete

Conversation

@mrCherry97
Copy link
Contributor

@mrCherry97 mrCherry97 commented Jan 9, 2025

Description

Changes proposed in this pull request:

  • add table with info about associated resources on delete
  • add warning, that user needs to remove associated resources before removing the module
  • disable button if there is some associated resources left
  • add onclick on the list items to navigate to the resource view on the all namespaces or cluster lvl

Related issue(s)
Closes #3345

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2025
@mrCherry97 mrCherry97 changed the title add list items feat: Information about associated resources in delete modal for modules Jan 9, 2025
@mrCherry97 mrCherry97 marked this pull request as ready for review January 14, 2025 13:25
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2025
);
};

const getAssciatedResources = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the function name :)

Suggested change
const getAssciatedResources = () => {
const getAssociatedResources = () => {

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 15, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 15, 2025
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mrCherry97 mrCherry97 added the lgtm Looks good to me! label Jan 15, 2025
@mrCherry97
Copy link
Contributor Author

/override tide

@kyma-bot
Copy link
Contributor

@mrCherry97: Overrode contexts on behalf of mrCherry97: tide

Details

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrCherry97 mrCherry97 merged commit 9f36ee5 into kyma-project:main Jan 15, 2025
26 of 27 checks passed
@mrCherry97 mrCherry97 deleted the module-delete branch January 15, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete module with managed resources and operator resources

4 participants