Skip to content

fix: Hide memory charts if no resource quota#3578

Merged
OliwiaGowor merged 1 commit intokyma-project:mainfrom
akucharska:memory-charts
Jan 10, 2025
Merged

fix: Hide memory charts if no resource quota#3578
OliwiaGowor merged 1 commit intokyma-project:mainfrom
akucharska:memory-charts

Conversation

@akucharska
Copy link
Contributor

@akucharska akucharska commented Jan 9, 2025

Description

Changes proposed in this pull request:

  • Hide memory requests/limits chart if resource quota is not present

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2025
@akucharska akucharska linked an issue Jan 9, 2025 that may be closed by this pull request
Memory requests and limits cards always show zero (namespace overview) #3572
Closed
@OliwiaGowor OliwiaGowor self-assigned this Jan 10, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 10, 2025
@OliwiaGowor OliwiaGowor merged commit b5abfbb into kyma-project:main Jan 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@OliwiaGowor OliwiaGowor

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Memory requests and limits cards always show zero (namespace overview)

3 participants

@akucharska @OliwiaGowor @kyma-bot