Skip to content

chore: set header limit to 24kB#3580

Merged
mrCherry97 merged 2 commits intokyma-project:mainfrom
dbadura:nodejs-headers
Jan 13, 2025
Merged

chore: set header limit to 24kB#3580
mrCherry97 merged 2 commits intokyma-project:mainfrom
dbadura:nodejs-headers

Conversation

@dbadura
Copy link
Contributor

@dbadura dbadura commented Jan 13, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@dbadura dbadura marked this pull request as ready for review January 13, 2025 12:07
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 13, 2025
mrCherry97
mrCherry97 previously approved these changes Jan 13, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 13, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 13, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 13, 2025
@dbadura dbadura changed the title chore: set limit backt to 80kb chore: set limit backt to 24kb Jan 13, 2025
@dbadura dbadura changed the title chore: set limit backt to 24kb chore: set limit backt to 24kB Jan 13, 2025
@dbadura dbadura changed the title chore: set limit backt to 24kB chore: set header limit to 24kB Jan 13, 2025
@mrCherry97 mrCherry97 merged commit 75e2dec into kyma-project:main Jan 13, 2025
47 of 57 checks passed
@dbadura dbadura deleted the nodejs-headers branch January 13, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@mrCherry97 mrCherry97

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbadura @mrCherry97 @kyma-bot