Merged
Conversation
kyma-bot
added
do-not-merge/work-in-progress
kyma-bot
added
size/S
kyma-bot
added
size/M
kyma-bot
added
size/L
mrCherry97
commented
Jan 29, 2025
| const skipModuleFn = () => { | ||
| const shouldShowManagedWarning = isManagedChanged; | ||
| const shouldShowChannelWarning = isEdited; | ||
| const shouldShowChannelWarning = showChannelChangeWarning; |
Contributor
Author
There was a problem hiding this comment.
I
Suggested change
| const shouldShowChannelWarning = showChannelChangeWarning; |
mrCherry97
commented
Jan 29, 2025
|
|
||
| useEffect(() => { | ||
| async function fetchModule() { | ||
| if (path.includes('undefined')) return; |
Contributor
Author
There was a problem hiding this comment.
resource?.resource === undefined
dbadura
requested review from
OliwiaGowor,
akucharska,
chriskari and
dbadura
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
akucharska
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Definition of done
backlog#4567