Skip to content

fix: Buttons overlapping in Header#3648

Merged
mrCherry97 merged 1 commit intokyma-project:mainfrom
OliwiaGowor:acc-header-overlap
Jan 31, 2025
Merged

fix: Buttons overlapping in Header#3648
mrCherry97 merged 1 commit intokyma-project:mainfrom
OliwiaGowor:acc-header-overlap

Conversation

@OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Jan 31, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • fixed buttons overlapping in header on 320px screens

Related issue(s)
Closes #3159

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Jan 31, 2025
@OliwiaGowor OliwiaGowor marked this pull request as ready for review January 31, 2025 09:15
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 31, 2025
@mrCherry97 mrCherry97 self-assigned this Jan 31, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 31, 2025
@mrCherry97 mrCherry97 merged commit be5cf32 into kyma-project:main Jan 31, 2025
86 of 89 checks passed
@OliwiaGowor OliwiaGowor deleted the acc-header-overlap branch February 14, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@mrCherry97 mrCherry97

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ACC-282.1 (Level AA) _ Modify Modules _ Menu, Button, Text _ Overlapping of Uis

3 participants

@OliwiaGowor @mrCherry97 @kyma-bot