Skip to content

refactor: Use separate script for provision and install kyma#3654

Merged
mrCherry97 merged 6 commits intokyma-project:mainfrom
dbadura:separate-setup-kyma
Feb 6, 2025
Merged

refactor: Use separate script for provision and install kyma#3654
mrCherry97 merged 6 commits intokyma-project:mainfrom
dbadura:separate-setup-kyma

Conversation

@dbadura
Copy link
Contributor

@dbadura dbadura commented Feb 3, 2025 •
edited by mrCherry97
Loading

Description

Changes proposed in this pull request:

  • use separate script to allow installing kyma without deleting k3d cluster

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2025
@dbadura dbadura force-pushed the separate-setup-kyma branch from e97b0ee to e716150 Compare February 4, 2025 15:29
mrCherry97
mrCherry97 requested changes Feb 6, 2025
View reviewed changes
@dbadura dbadura force-pushed the separate-setup-kyma branch from 43de500 to 11f6c57 Compare February 6, 2025 09:24
mrCherry97
mrCherry97 previously approved these changes Feb 6, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 6, 2025
@mrCherry97
Copy link
Contributor

mrCherry97 commented Feb 6, 2025

/override tide

1 similar comment
@mrCherry97
Copy link
Contributor

mrCherry97 commented Feb 6, 2025

/override tide

@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 6, 2025

@mrCherry97: Overrode contexts on behalf of mrCherry97: tide

Details

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 6, 2025

@mrCherry97: Overrode contexts on behalf of mrCherry97: tide

Details

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Feb 6, 2025
mrCherry97
mrCherry97 requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping me, when PR will be ready.

dbadura and others added 2 commits February 6, 2025 11:44
@dbadura
fix typo
e598066
@dbadura @mrCherry97
Update .github/scripts/install-kyma.sh
8006b36 
Co-authored-by: Mateusz Wisniewski <mwisnia97@gmail.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 6, 2025
@mrCherry97
Copy link
Contributor

mrCherry97 commented Feb 6, 2025

/override tide

@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 6, 2025

@mrCherry97: Overrode contexts on behalf of mrCherry97: tide

Details

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrCherry97 mrCherry97 merged commit 378f166 into kyma-project:main Feb 6, 2025
15 checks passed
@dbadura dbadura deleted the separate-setup-kyma branch February 6, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@mrCherry97 mrCherry97

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbadura @mrCherry97 @kyma-bot