Skip to content

feat: Add additional info on Module delete modal#3695

Merged
mrCherry97 merged 1 commit intokyma-project:mainfrom
mrCherry97:feat-delete-message
Feb 13, 2025
Merged

feat: Add additional info on Module delete modal#3695
mrCherry97 merged 1 commit intokyma-project:mainfrom
mrCherry97:feat-delete-message

Conversation

@mrCherry97
Copy link
Contributor

@mrCherry97 mrCherry97 commented Feb 12, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • feat: Add additional info on Module delete modal

Related issue(s)
backlog#6746

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@mrCherry97 mrCherry97 marked this pull request as ready for review February 12, 2025 13:31
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 12, 2025
@mrCherry97 mrCherry97 enabled auto-merge (squash) February 12, 2025 13:44
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 12, 2025
@mrCherry97 mrCherry97 merged commit 8ef9dc7 into kyma-project:main Feb 13, 2025
54 of 60 checks passed
@mrCherry97 mrCherry97 deleted the feat-delete-message branch February 13, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbadura dbadura dbadura approved these changes

@grego952 grego952 grego952 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@dbadura dbadura

@grego952 grego952

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrCherry97 @dbadura @grego952 @kyma-bot