feat: Update cpu and memory charts on namespace#3711
Merged
mrCherry97 merged 28 commits intokyma-project:mainfrom Mar 3, 2025
Merged
feat: Update cpu and memory charts on namespace#3711mrCherry97 merged 28 commits intokyma-project:mainfrom
mrCherry97 merged 28 commits intokyma-project:mainfrom
Conversation
kyma-bot
added
do-not-merge/work-in-progress
KonradPietocha
changed the title
KonradPietocha
requested review from
OliwiaGowor,
akucharska,
chriskari,
dbadura and
mrCherry97
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
dbadura
requested changes
Feb 18, 2025
| return podsMetrics.reduce((accData, pod) => { | ||
| return { | ||
| cpu: { | ||
| usage: accData.cpu.usage + (pod?.cpu?.usage ?? 0), |
Contributor
There was a problem hiding this comment.
I would consider to wrap all addition by getCpus or getBytes functions because sometimes k8s can return values with different prefix.
dbadura
requested changes
Feb 20, 2025
Contributor
dbadura
left a comment
dbadura
left a comment
There was a problem hiding this comment.
I have encountered such bug?
I deployed function with XS size and add any resource quota. The memory usage is 0. Is it okay?
dbadura
reviewed
Feb 20, 2025
tests/integration/tests/namespace/test-namespace-overview.spec.js
Outdated
Show resolved
Hide resolved
dbadura
reviewed
Feb 21, 2025
kyma-bot
added
size/XXL
kyma-bot
added
size/XL
dbadura
approved these changes
Mar 2, 2025
Contributor
|
New changes are detected. LGTM label has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Closes #3592
Definition of done
backlog#4567