Skip to content

fix: Truncation of title and extension form#3724

Merged
akucharska merged 4 commits intokyma-project:mainfrom
akucharska:truncation-of-things
Feb 21, 2025
Merged

fix: Truncation of title and extension form#3724
akucharska merged 4 commits intokyma-project:mainfrom
akucharska:truncation-of-things

Conversation

@akucharska
Copy link
Contributor

@akucharska akucharska commented Feb 20, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • Truncation of title on resource list and details page
  • Truncation of form on create extension page

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2025
@akucharska akucharska linked an issue Feb 20, 2025 that may be closed by this pull request
ACC-282.1 (Level AA) _ Modify Modules _ Text _ Truncation of text #3160
Closed
@akucharska akucharska changed the title Fix: Truncation of title and extension form fix: Truncation of title and extension form Feb 20, 2025
OliwiaGowor
OliwiaGowor reviewed Feb 21, 2025
View reviewed changes
src/shared/components/DynamicPageComponent/DynamicPageComponent.scss Outdated

@media (max-width: 340px) {
.bold-title {
text-wrap-mode: wrap;
Copy link
Contributor

@OliwiaGowor OliwiaGowor Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could make it a default for all screen widths so the titles are easily readable

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 21, 2025
@akucharska akucharska merged commit 9ab006e into kyma-project:main Feb 21, 2025
18 checks passed
@akucharska akucharska deleted the truncation-of-things branch February 21, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@OliwiaGowor OliwiaGowor

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ACC-282.1 (Level AA) _ Modify Modules _ Text _ Truncation of text

3 participants

@akucharska @OliwiaGowor @kyma-bot