Skip to content

fix: Setup Kyma in tests and Infinite loop in GenericList#3737

Merged
mrCherry97 merged 11 commits intokyma-project:mainfrom
mrCherry97:fix-genericlist
Mar 3, 2025
Merged

fix: Setup Kyma in tests and Infinite loop in GenericList#3737
mrCherry97 merged 11 commits intokyma-project:mainfrom
mrCherry97:fix-genericlist

Conversation

@mrCherry97
Copy link
Contributor

Description

Changes proposed in this pull request:

  • fix: Infinite loop in GenericList

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2025
@mrCherry97 mrCherry97 marked this pull request as ready for review February 28, 2025 11:27
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 28, 2025
@mrCherry97
Copy link
Contributor Author

To test it:

  1. Create k3d cluster
  2. Connect to busola
  3. Go to some resource which has 0 entries

Second option:

  1. Apply Kyma CRD
  2. Apply Kyma CR
  3. Check Modules view

@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2025
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 3, 2025
@mrCherry97 mrCherry97 changed the title fix: Infinite loop in GenericList fix: Setup Kyma in tests and Infinite loop in GenericList Mar 3, 2025
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 3, 2025
currentModuleTemplate?.spec?.info?.documentation ||
currentModuleTemplate?.metadata?.annotations[
'operator.kyma-project.io/doc-url'
];
Copy link
Contributor

@chriskari chriskari Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be

  const moduleDocs =
     currentModuleTemplate?.spec?.info?.documentation ||
     currentModuleTemplate?.metadata?.annotations[
       'operator.kyma-project.io/doc-url'
     ];

@mrCherry97 mrCherry97 enabled auto-merge (squash) March 3, 2025 09:56
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 3, 2025
@mrCherry97 mrCherry97 merged commit 508afa5 into kyma-project:main Mar 3, 2025
18 checks passed
@mrCherry97 mrCherry97 deleted the fix-genericlist branch March 3, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants