fix: Stop flickering the delete box#3776
Merged
KonradPietocha merged 13 commits intokyma-project:mainfrom Mar 26, 2025
Merged
Conversation
KonradPietocha
requested review from
OliwiaGowor,
akucharska,
chriskari,
dbadura and
mrCherry97
as code owners
KonradPietocha
added
the
do-not-merge/work-in-progress
KonradPietocha
changed the title
KonradPietocha
removed
the
do-not-merge/work-in-progress
KonradPietocha
changed the title
OliwiaGowor
reviewed
Mar 25, 2025
Contributor
OliwiaGowor
left a comment
OliwiaGowor
left a comment
There was a problem hiding this comment.
Could something also be done with the jump when opening the delete dialog or is it UI5 issue?
Screen.Recording.2025-03-25.at.16.41.27.mov
|
|
||
| export const checkSelectedModule = ( | ||
| module: { name: string }, | ||
| layoutState: { midColumn: { resourceType: string } }, |
Contributor
There was a problem hiding this comment.
We have the ColumnLayoutState type, could it be used here?
Comment on lines
234
to
239
| const resourceType = layoutState.midColumn.resourceType; | ||
| const resourceTypeDotIndex = resourceType.indexOf('.'); | ||
| const resourceTypeBase = | ||
| resourceTypeDotIndex !== -1 | ||
| ? resourceType.substring(0, resourceTypeDotIndex) | ||
| : resourceType; |
Contributor
There was a problem hiding this comment.
Would something like this work?
const [resourceTypeBase] = layoutState.midColumn.resourceType.split('.');
OliwiaGowor
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Closes #3721
Definition of done
backlog#4567