feat: Secure proxy endpoint#3813
Merged
chriskari merged 9 commits intokyma-project:mainfrom Apr 9, 2025
Merged
Conversation
chriskari
requested review from
OliwiaGowor,
akucharska,
dbadura and
mrCherry97
as code owners
5 tasks
dbadura
reviewed
Apr 8, 2025
Comment on lines
+60
to
+70
| if (parsedUrl.protocol !== 'https:') { | ||
| return res.status(403).send('Request Forbidden'); | ||
| } | ||
|
|
||
| if (isLocalDomain(parsedUrl.hostname)) { | ||
| return res.status(403).send('Request Forbidden'); | ||
| } | ||
|
|
||
| if (net.isIP(parsedUrl.hostname) !== 0) { | ||
| return res.status(403).send('Request Forbidden'); | ||
| } |
Contributor
There was a problem hiding this comment.
We can move it to separete function for readibility
backend/proxy.js
Outdated
Comment on lines
+72
to
+83
| // Perform DNS resolution to check for private IPs | ||
| try { | ||
| const addresses = await dns.lookup(parsedUrl.hostname, { all: true }); | ||
| for (const addr of addresses) { | ||
| if (isPrivateIp(addr.address)) { | ||
| return res.status(403).send('Request Forbidden'); | ||
| } | ||
| } | ||
| } catch (dnsError) { | ||
| // If DNS lookup fails, we block the request for safety. | ||
| return res.status(403).send('Request Forbidden'); | ||
| } |
Contributor
There was a problem hiding this comment.
We can move it to separete function for readibility
dbadura
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#3682
Definition of done
backlog#4567