fix: Monaco Editor is stuck in loading state after page refresh#3838
Merged
mrCherry97 merged 5 commits intokyma-project:mainfrom Apr 9, 2025
Merged
fix: Monaco Editor is stuck in loading state after page refresh#3838mrCherry97 merged 5 commits intokyma-project:mainfrom
mrCherry97 merged 5 commits intokyma-project:mainfrom
Conversation
OliwiaGowor
requested review from
akucharska,
chriskari,
dbadura and
mrCherry97
as code owners
mrCherry97
requested changes
Apr 8, 2025
Contributor
mrCherry97
left a comment
mrCherry97
left a comment
There was a problem hiding this comment.
Please also check if this fix could potentially resolve this issue: #3291
| } | ||
|
|
||
| const { schema, loading, error } = useGetSchema({ | ||
| const { fetchedSchema, loading, error } = useGetSchema({ |
Contributor
There was a problem hiding this comment.
Maybe make like this to have it more clear
Suggested change
| const { fetchedSchema, loading, error } = useGetSchema({ | |
| const { schemas: fetchedSchema, loading, error } = useGetSchema({ |
| const { fetchedSchema, loading, error } = useGetSchema({ | ||
| schemaId, | ||
| skip: autocompletionDisabled, | ||
| skip: autocompletionDisabled | !!predefinedSchema, |
Contributor
There was a problem hiding this comment.
Suggested change
| skip: autocompletionDisabled | !!predefinedSchema, | |
| skip: autocompletionDisabled || !!predefinedSchema, |
mrCherry97
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Closes #3819, closes #3291
Definition of done
backlog#4567