Skip to content

refactor: FormOpen state and isResourceEdit state#3866

Merged
OliwiaGowor merged 8 commits intokyma-project:mainfrom
chriskari:fix-formOpen-state
Apr 18, 2025
Merged

refactor: FormOpen state and isResourceEdit state#3866
OliwiaGowor merged 8 commits intokyma-project:mainfrom
chriskari:fix-formOpen-state

Conversation

@chriskari
Copy link
Contributor

@chriskari chriskari commented Apr 15, 2025

Description

Changes proposed in this pull request:

  • introduced custom hook useFormNavigation to safely handle navigation away from open forms that have been edited
  • introduced custom hook useFormEditTracking to allow reliable and fast tracking if the resource has been edited
  • adjusted the rest of the code base accordingly

Related issue(s)
#3810

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@chriskari chriskari linked an issue Apr 15, 2025 that may be closed by this pull request
@OliwiaGowor OliwiaGowor self-assigned this Apr 18, 2025
@OliwiaGowor OliwiaGowor merged commit 1dc819b into kyma-project:main Apr 18, 2025
19 checks passed
@chriskari chriskari deleted the fix-formOpen-state branch April 22, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FormOpen state is incorrect after edit

2 participants