Skip to content

fix: Improve updating logic of initialResource#3878

Merged
mrCherry97 merged 17 commits intokyma-project:mainfrom
chriskari:fix-formOpen-state
Apr 25, 2025
Merged

fix: Improve updating logic of initialResource#3878
mrCherry97 merged 17 commits intokyma-project:mainfrom
chriskari:fix-formOpen-state

Conversation

@chriskari
Copy link
Contributor

@chriskari chriskari commented Apr 22, 2025

Description

Changes proposed in this pull request:

  • refactored the code to remove initialUnchangedResource
  • update state of resource and initialResource should its value update

Related issue(s)
#3810

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@chriskari chriskari changed the title fix: improve updating logic of initialResource fix: Improve updating logic of initialResource Apr 22, 2025
@chriskari chriskari linked an issue Apr 22, 2025 that may be closed by this pull request
@chriskari chriskari force-pushed the fix-formOpen-state branch from 5aa2448 to 4aeaa9d Compare April 22, 2025 10:38
resource={kymaResource}
initialResource={initialResource}
initialUnchangedResource={initialUnchangedResource}
updateInitialResource={() => {}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is empty?

layoutNumber="startColumn"
resetLayout
initialUnchangedResource={initialUnchangedResource}
updateInitialResource={() => {}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is empty?

@chriskari chriskari force-pushed the fix-formOpen-state branch from c77a3ec to d408042 Compare April 25, 2025 07:38
@mrCherry97 mrCherry97 merged commit e8c63ed into kyma-project:main Apr 25, 2025
18 of 20 checks passed
@chriskari chriskari deleted the fix-formOpen-state branch June 19, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FormOpen state is incorrect after edit

3 participants