Skip to content

chore: Bump openapi-schema-to-json-schema package#3900

Merged
mrCherry97 merged 1 commit intokyma-project:mainfrom
OliwiaGowor:bump-openapi-schema-to-json-shcema
May 5, 2025
Merged

chore: Bump openapi-schema-to-json-schema package#3900
mrCherry97 merged 1 commit intokyma-project:mainfrom
OliwiaGowor:bump-openapi-schema-to-json-shcema

Conversation

@OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Apr 30, 2025

Description

Changes proposed in this pull request:

  • Bumped openapi-schema-to-json-schema package to 5.1.0
  • Fixed accesibleName error
    Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@OliwiaGowor OliwiaGowor mentioned this pull request Apr 29, 2025
45 tasks
@OliwiaGowor OliwiaGowor marked this pull request as ready for review April 30, 2025 10:25
<div className={classnames} onClick={onClick}>
<RadialChart
accessibleName={'Radial chart'}
aria-label={'Radial chart'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary? We added that because of accessibility validation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's throwing errors because there is no property accessibleName for the RadialChart
image

@mrCherry97 mrCherry97 self-assigned this Apr 30, 2025
@mrCherry97 mrCherry97 enabled auto-merge (squash) May 5, 2025 07:03
@mrCherry97 mrCherry97 merged commit e137adf into kyma-project:main May 5, 2025
101 of 106 checks passed
@OliwiaGowor OliwiaGowor deleted the bump-openapi-schema-to-json-shcema branch August 4, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants