Skip to content

fix: Module deletion#3922

Merged
dbadura merged 3 commits intokyma-project:mainfrom
dbadura:fix-module-delete
May 16, 2025
Merged

fix: Module deletion#3922
dbadura merged 3 commits intokyma-project:mainfrom
dbadura:fix-module-delete

Conversation

@dbadura
Copy link
Contributor

@dbadura dbadura commented May 15, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • uncomment delete tests
  • fix delete module

Related issue(s)
#3920

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@dbadura dbadura added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2025
@dbadura dbadura linked an issue May 15, 2025 that may be closed by this pull request
Delete module fails with message "resourceVersion should not be set..." #3920
Closed
@dbadura dbadura changed the title fix: module deletion fix: Module deletion May 15, 2025
@dbadura dbadura enabled auto-merge (squash) May 15, 2025 12:35
@dbadura dbadura merged commit 66e18bf into kyma-project:main May 16, 2025
20 of 29 checks passed
@dbadura dbadura deleted the fix-module-delete branch May 16, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chriskari chriskari chriskari approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

@KonradPietocha KonradPietocha Awaiting requested review from KonradPietocha KonradPietocha is a code owner

Assignees

@chriskari chriskari

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Delete module fails with message "resourceVersion should not be set..."

2 participants

@dbadura @chriskari