feat: Add community modules by akucharska · Pull Request #3947 · kyma-project/busola

akucharska · 2025-06-04T14:19:17Z

Description

Changes proposed in this pull request:

Add view for installing community modules

Related issue(s)

Definition of done

The PR's title starts with one of the following prefixes:
- feat: A new feature
- fix: A bug fix
- docs: Documentation only changes
- refactor: A code change that neither fixes a bug nor adds a feature
- test: Adding tests
- revert: Revert commit
- chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
Explain clearly why you created the PR and what changes it introduces
All necessary steps are delivered, for example, tests, documentation, merging

dbadura · 2025-06-30T11:27:03Z

src/components/KymaModules/support.ts

+  return resources;
+};
+
+async function getResourcesYamls(link: string, post: Function) {


It look the same as postForCommunityResources from deleteModuleHelpers.tsx

mrCherry97

Please double check if there is more functions with are the same or very similar which can be moved to like support or shared for adding functionalities and called in ModulesAdd and CommunityModulesAdd

mrCherry97 · 2025-07-01T07:31:31Z

src/resources/other/kymaModules.routes.js

+                }}
+              />
+            )}
+            {layoutState?.showCreate?.createType !== 'community' && (


mrCherry97 · 2025-07-01T07:35:13Z

src/components/KymaModules/components/CommunityModulesList.tsx

+        resourceType: 'kymas',
+        rawResourceTypeName: 'Kyma',
+        namespaceId: 'kyma-system',
+        apiGroup: 'operator.kyma-project.io',
+        apiVersion: 'v1beta2',


Do we need such specificity? In case of a Kyma update, we need to remember to change it.

mrCherry97 · 2025-07-01T07:58:34Z

src/components/KymaModules/CommunityModulesAddModule.js

+    if (!existingModule && !isAlreadyInstalled) {
+      moduleMetaRelase?.spec.channels.forEach(channel => {
+        if (!acc.find(item => item.name === name)) {
+          acc.push({
+            name: name,
+            channels: [
+              {
+                channel: channel.channel,
+                version: channel.version,
+                isBeta: moduleMetaRelase.spec.beta ?? false,
+                isMetaRelease: true,
+                resources: module.spec.resources,
+              },
+            ],
+            docsUrl: module.spec.info.documentation,
+            icon: {
+              link: module.spec?.info?.icons[0]?.link,
+              name: module.spec?.info?.icons[0]?.name,
+            },
+          });
+        } else {
+          acc
+            .find(item => item.name === name)
+            .channels.push({
+              channel: channel.channel,
+              version: channel.version,
+              isBeta: moduleMetaRelase.spec.beta ?? false,
+              isMetaRelease: true,
+              resources: module.spec.resources,
+            });
+        }
+      });
+    }


This could be moved to a separate function and called dynamically in ModulesAdd and CommunityModulesAdd

dbadura · 2025-07-01T11:16:20Z

src/components/KymaModules/CommunityModulesAddModule.js

+  const modulesAddData = moduleTemplates?.items.reduce((acc, module) => {
+    const name = module.metadata.labels['operator.kyma-project.io/module-name'];
+    const existingModule = acc.find(item => {
+      return item.metadata.name === name;


Busola crashes when there is the same module in acc.
It tries to access metadata.name which is not available because it's custom data structure.

I created 2 busola moduleTempaltes with different version.

apiVersion: operator.kyma-project.io/v1beta2 kind: ModuleTemplate metadata: annotations: operator.kyma-project.io/is-cluster-scoped: "false" labels: operator.kyma-project.io/module-name: busola name: busola-fast namespace: kyma-system spec: channel: fast associatedResources: - group: operator.kyma-project.io kind: ClusterIP version: v1alpha2 data: apiVersion: operator.kyma-project.io/v1alpha1 kind: ClusterIP metadata: name: cluster-ip-zones spec: nodeSpreadLabel: topology.kubernetes.io/zone descriptor: component: componentReferences: [] name: kyma-project.io/module/cluster-ip provider: '{"name":"kyma-project.io","labels":[{"name":"kyma-project.io/built-by","value":"modulectl","version":"v1"}]}' repositoryContexts: - baseUrl: http://k3d-oci.localhost:5001 componentNameMapping: urlPath type: OCIRegistry resources: - access: localReference: sha256:b88d172173d41c7b0799512718e598efa5643e9eb3aeebbf88fd8e5e6e18098f mediaType: application/x-tar referenceName: raw-manifest type: localBlob digest: hashAlgorithm: SHA-256 normalisationAlgorithm: genericBlobDigest/v1 value: b88d172173d41c7b0799512718e598efa5643e9eb3aeebbf88fd8e5e6e18098f name: raw-manifest relation: local type: directory version: 0.0.29 - access: localReference: sha256:633d91a28e03e1bcb495095e92430a2d996e13faaa15ead90cc180514cf5a2c3 mediaType: application/x-tar referenceName: default-cr type: localBlob digest: hashAlgorithm: SHA-256 normalisationAlgorithm: genericBlobDigest/v1 value: 633d91a28e03e1bcb495095e92430a2d996e13faaa15ead90cc180514cf5a2c3 name: default-cr relation: local type: directory version: 0.0.29 sources: - access: commit: 106643ead24aff8da197fc89a46ce546193ea8f1 repoUrl: https://github.com/pbochynski/cluster-ip.git type: gitHub labels: - name: git.kyma-project.io/ref value: HEAD version: v1 name: module-sources type: Github version: 0.0.29 version: 0.0.29 meta: schemaVersion: v2 info: documentation: https://github.com/pbochynski icons: - link: https://raw.githubusercontent.com/pbochynski/cluster-ip/refs/heads/main/logo.png name: module-icon repository: https://github.com/pbochynski/cluster-ip.git manager: group: apps kind: Deployment name: busola namespace: default version: v1 mandatory: false moduleName: busola requiresDowntime: false resources: - link: https://github.com/kyma-project/busola/releases/download/v0.0.13/busola.yaml name: rawManifest version: 0.0.13

apiVersion: operator.kyma-project.io/v1beta2 kind: ModuleTemplate metadata: annotations: operator.kyma-project.io/is-cluster-scoped: "false" labels: operator.kyma-project.io/module-name: busola name: busola-regular namespace: kyma-system spec: channel: regular associatedResources: - group: operator.kyma-project.io kind: ClusterIP version: v1alpha2 data: apiVersion: operator.kyma-project.io/v1alpha1 kind: ClusterIP metadata: name: cluster-ip-zones spec: nodeSpreadLabel: topology.kubernetes.io/zone descriptor: component: componentReferences: [] name: kyma-project.io/module/cluster-ip provider: '{"name":"kyma-project.io","labels":[{"name":"kyma-project.io/built-by","value":"modulectl","version":"v1"}]}' repositoryContexts: - baseUrl: http://k3d-oci.localhost:5001 componentNameMapping: urlPath type: OCIRegistry resources: - access: localReference: sha256:b88d172173d41c7b0799512718e598efa5643e9eb3aeebbf88fd8e5e6e18098f mediaType: application/x-tar referenceName: raw-manifest type: localBlob digest: hashAlgorithm: SHA-256 normalisationAlgorithm: genericBlobDigest/v1 value: b88d172173d41c7b0799512718e598efa5643e9eb3aeebbf88fd8e5e6e18098f name: raw-manifest relation: local type: directory version: 0.0.29 - access: localReference: sha256:633d91a28e03e1bcb495095e92430a2d996e13faaa15ead90cc180514cf5a2c3 mediaType: application/x-tar referenceName: default-cr type: localBlob digest: hashAlgorithm: SHA-256 normalisationAlgorithm: genericBlobDigest/v1 value: 633d91a28e03e1bcb495095e92430a2d996e13faaa15ead90cc180514cf5a2c3 name: default-cr relation: local type: directory version: 0.0.29 sources: - access: commit: 106643ead24aff8da197fc89a46ce546193ea8f1 repoUrl: https://github.com/pbochynski/cluster-ip.git type: gitHub labels: - name: git.kyma-project.io/ref value: HEAD version: v1 name: module-sources type: Github version: 0.0.29 version: 0.0.29 meta: schemaVersion: v2 info: documentation: https://github.com/pbochynski icons: - link: https://raw.githubusercontent.com/pbochynski/cluster-ip/refs/heads/main/logo.png name: module-icon repository: https://github.com/pbochynski/cluster-ip.git manager: group: apps kind: Deployment name: busola namespace: default version: v1 mandatory: false moduleName: busola requiresDowntime: false resources: - link: https://github.com/kyma-project/busola/releases/download/v0.0.10/busola.yaml name: rawManifest version: 0.0.10

public/i18n/en.yaml

src/components/KymaModules/deleteModulesHelpers.tsx

src/components/KymaModules/components/communityModulesHelpers.ts

src/components/KymaModules/support.ts

OliwiaGowor · 2025-07-14T11:53:43Z

src/components/KymaModules/CommunityModulesAddModule.tsx

+                {/* {checkIfSelectedModuleIsBeta() ? (
+                <MessageStrip
+                  key={'beta'}
+                  design="Critical"
+                  hideCloseButton
+                  className="sap-margin-top-small"
+                >
+                  {t('kyma-modules.beta-alert')}
+                </MessageStrip>
+              ) : null} */}


Do we need this?

OliwiaGowor · 2025-07-14T12:05:31Z

After refreshing the page with either the Add Community Modules or the Add Modules form open, the forms are not being loaded, and I see an empty column

Screen.Recording.2025-07-14.at.14.02.39.mov

src/components/KymaModules/components/CommunityModulesCard.js

src/components/KymaModules/CommunityModulesAddModule.tsx

src/components/KymaModules/providers/CommunityModuleProvider.js

src/components/KymaModules/components/CommunityModulesList.tsx

src/components/KymaModules/CommunityModulesAddModule.tsx

Handover to Damian

dbadura

Something is wrong I can't install busola.

src/components/KymaModules/CommunityModulesAddModule.tsx

dbadura

I found out that installing doesn't work when using Firefox.

Work in progress

fbea11c

akucharska linked an issue Jun 4, 2025 that may be closed by this pull request

Install community modules (not managed) #3350

Closed

7 tasks

akucharska added 10 commits June 5, 2025 11:47

Merge branch 'main' into add-community-modules

db6439e

Fix refreshing with create opened

e15471a

Fix refreshing with create opened

bfee381

Show add community modules form

f63fbb0

Have version

d1eb91a

prepare list of resourcesToAply

d419b9d

Partial commit without backend

2e18258

Uplode yamls

2f5e55f

Merge branch 'main' into add-community-modules

0e1a1e4

Clean up

49049a2

akucharska marked this pull request as ready for review June 27, 2025 11:06

akucharska requested review from a team, KonradPietocha, OliwiaGowor, chriskari, dbadura and mrCherry97 as code owners June 27, 2025 11:06

mrCherry97 self-assigned this Jun 30, 2025

Clean up

5a4407d

dbadura reviewed Jun 30, 2025

View reviewed changes

mrCherry97 previously requested changes Jul 1, 2025

View reviewed changes

Remove duplicated function

dccad49

dbadura reviewed Jul 1, 2025

View reviewed changes

dbadura self-assigned this Jul 1, 2025

Move getModulesAddData to separate file

2b7b101

dbadura reviewed Jul 1, 2025

View reviewed changes

public/i18n/en.yaml Show resolved Hide resolved

Show form id createType is right

0a9f2ad

Sawthis closed this Jul 4, 2025

akucharska added 10 commits July 10, 2025 14:55

clean up

f787f14

clean up

e5dfef8

prettier

dead59e

rename

429cf07

rename

aaa27cc

cleanup

946a4c0

clean up

0b0a5d1

remove file

8472ffc

Merge branch 'main' into add-community-modules

dfe5231

cleanup after merge

6f1b976

dbadura assigned OliwiaGowor and unassigned mrCherry97 Jul 11, 2025

dbadura requested changes Jul 14, 2025

View reviewed changes

src/components/KymaModules/deleteModulesHelpers.tsx Outdated Show resolved Hide resolved

src/components/KymaModules/components/communityModulesHelpers.ts Outdated Show resolved Hide resolved

src/components/KymaModules/support.ts Outdated Show resolved Hide resolved

Review changes

2af0277

OliwiaGowor reviewed Jul 14, 2025

View reviewed changes

dbadura requested changes Jul 14, 2025

View reviewed changes

Fix delete

30cb2f7

dbadura requested changes Jul 14, 2025

View reviewed changes

src/components/KymaModules/CommunityModulesAddModule.tsx Outdated Show resolved Hide resolved

akucharska added 3 commits July 15, 2025 08:44

review changes

7a37336

Rename component, combine getInstalledModules

38b68a9

Fix deleting if no associatedResourceLeft

e180fb1

dbadura reviewed Jul 16, 2025

View reviewed changes

Fix install

367fde9

dbadura approved these changes Jul 17, 2025

View reviewed changes

dbadura enabled auto-merge (squash) July 17, 2025 09:28

grego952 approved these changes Jul 17, 2025

View reviewed changes

dbadura merged commit 5d24346 into kyma-project:main Jul 17, 2025
22 of 28 checks passed

akucharska deleted the add-community-modules branch July 17, 2025 09:41

Conversation

akucharska commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbadura Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

mrCherry97 left a comment

Choose a reason for hiding this comment

Uh oh!

mrCherry97 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

mrCherry97 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

mrCherry97 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

dbadura Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OliwiaGowor Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

OliwiaGowor commented Jul 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dbadura left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dbadura left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

akucharska commented Jun 4, 2025 •

edited

Loading

dbadura Jul 1, 2025 •

edited

Loading