Skip to content

fix: Adding own module-template CM with github raw link #4632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akucharska merged 4 commits into from
Feb 19, 2026
Merged

fix: Adding own module-template CM with github raw link #4632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
113b2a8
fix: Handle raw github links
akucharska Feb 16, 2026
957249f
Merge branch 'main' into modules-raw-link
akucharska Feb 17, 2026
2c4d4f3
Adjust tests
akucharska Feb 17, 2026
7d47244
Adjust tests
akucharska Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/modules/communityRouter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ async function handleGetCommunityResource(req, res) {
try {
const url = new URL(link);
// Only allow HTTPS protocol and restrict to specific trusted domains.
const allowedDomains = ['github.com', 'github.io'];
const allowedDomains = ['githubusercontent.com', 'github.com', 'github.io'];
if (
url.protocol !== 'https:' ||
!allowedDomains.some((domain) => url.hostname.endsWith(domain))
Expand Down
2 changes: 1 addition & 1 deletion src/components/Modules/community/components/AddSourceYamls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ export const AddSourceYamls = () => {
if (allTemplatesInstalled) {
return (
<>
<Text>
<Text data-testid="error-all-modules-installed">
{t('modules.community.source-yaml.all-modules-installed')}
</Text>
{displayExistingModulesList(existingModuleTemplates)}
Expand Down
19 changes: 14 additions & 5 deletions tests/integration/tests/kyma-cluster/test-community-modules.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,6 @@ context('Test Community Modules views', () => {
// Open Add YAML
cy.get('[accessible-name="add-yamls"]').click();

// Uncomment and adjust with https://github.com/kyma-project/busola/issues/4587
// cy.get('[accessible-name="Source YAML URL"]').click().type(
// 'https://raw.githubusercontent.com/kyma-project/community-modules/main/all-modules.yaml',
// );

// Open Add to Namespace select
cy.get(`[header-text="Add Source YAML"]:visible`)
.find('[data-testid="add-to-namespace-select"]')
Expand All @@ -109,6 +104,20 @@ context('Test Community Modules views', () => {
// Click of default namespace
cy.get('ui5-option-custom:visible').contains('default').click();

// Check access to raw github files
cy.get('[accessible-name="Source YAML URL"]')
.find('input')
.click()
.clear()
.type(
'https://raw.githubusercontent.com/kyma-project/busola/refs/heads/main/tests/integration/fixtures/community-modules/busola-0-12.yaml',
);

// Check if error 'all modules installed' is displayed
cy.get('[data-testid="error-all-modules-installed"]')
.contains('All modules in this YAML are already installed.')
.should('be.visible');

cy.get('ui5-button:visible').contains('Cancel').click();
});

Expand Down
Loading