[ON-HOLD][POC] Gateway API#1974
Open
kolodziejczak wants to merge 16 commits into
Open
Conversation
Contributor
Control PanelHi, I'm an AI-powered Review Bot that helps you with summarizing and reviewing pull requests.
💌 Have ideas or want to contribute? Create an issue and share your thoughts with us! Made with ❤️ by Hyperspace. |
2c2a8c0 to
7b39718
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR is PARKED
Date frozen: April 2026
Reason: Feature rethinking/redesign - not moving forward at this time with just installation and uninstallation in Istio module.
Decision: The implementation is complete, but need to be tested/double-checked the feature will not be merged in its current form.
If you are picking this up in the future, read this first:
What is done:
GatewayAPICRDManager— Install / Uninstall logic ingateway_api_crds.gokyma-project.io/module=istiolabelgateway_api_resources.go(only checks module-managed CRDs)GatewayAPICRsDanglingcondition on Istio CR when deletion is blockeddocs/contributor/adr/0017-support-for-gateway-api.mdWhat is NOT done / known gaps:
spec.experimental.enableGatewayAPI *boolshould be migrated tospec.experimental.gatewayAPI.enableCRD *boolsub-struct for future extensibility - as described in ADRlastAppliedCofigis being updated and module doesn't try to uninstall CRDs which were blocked by existing CRs)gateway_api_crds.goweren't updatedexperimentalKey decisions made (see ADR for full context):
*boolis intentional - nil = never enabled, false = explicitly disabledPre-Merge Checklist
Consider all the following items. If your contribution violates any of them, or you are not sure about it, add a comment to the PR.
make manifestsand committed the changes before the merge.Related issues