fix: remove DATABASE_USER from log messages to avoid sensitive data exposure#1200
fix: remove DATABASE_USER from log messages to avoid sensitive data exposure#1200ruanxin wants to merge 2 commits into
Conversation
…xposure DATABASE_USER is a credential value and must not appear in log output. Replace log lines that interpolate it with generic messages. Addresses Checkmarx SAST finding: - Filtering_Sensitive_Logs in doc_indexer/src/main.py (line 109)
SummaryThe following content is AI-generated and provides a summary of the pull request: Fix: Remove
|
There was a problem hiding this comment.
The changes look correct and focused. The PR removes DATABASE_USER from two log messages. Let me check the broader file for any remaining sensitive data in log messages to see if the fix is complete.
The fix is complete — no other log messages in the file reference DATABASE_USER, DATABASE_PASSWORD, or other credentials. The two changed lines are the only places where DATABASE_USER appeared in log output.
The changes are minimal, correct, and directly address the stated security finding. Both modified log messages convey the same operational meaning without exposing the database username. No issues to flag.
This is a clean, focused fix that correctly removes credential values from log output to address the Checkmarx SAST finding. No additional issues were found in the changed code.
PR Bot Information
Version: 1.21.1
- File Content Strategy: Full file content
- Review Focus Files:
- Correlation ID:
bb219aed-ae01-4bf5-a3db-587085b29c7f - LLM:
anthropic--claude-4.6-sonnet - Event Trigger:
pull_request.opened
Summary
DATABASE_USERcredential value from log messages indoc_indexer/src/main.pyf"No tables found for user {DATABASE_USER}."andf"HANA tables for user {DATABASE_USER}:..."with generic messages that don't expose credential valuesAddresses Checkmarx SAST finding (severity: LOW):
Filtering_Sensitive_Logsindoc_indexer/src/main.py(line 109)Test plan