Assign multiple hyperscaler accounts for global accounts with a large…#2894
Draft
MarekMichali wants to merge 9 commits intokyma-project:mainfrom
Draft
Assign multiple hyperscaler accounts for global accounts with a large…#2894MarekMichali wants to merge 9 commits intokyma-project:mainfrom
MarekMichali wants to merge 9 commits intokyma-project:mainfrom
Conversation
… number of clusters
|
Add one of following labels |
MarekMichali
commented
Feb 19, 2026
Comment on lines
+330
to
+334
|
|
||
| func (c *Client) GetShootCountPerCredentialsBinding() (map[string]int, error) { | ||
| shoots, err := c.GetShoots() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("while listing shoots: %w", err) |
Contributor
Author
There was a problem hiding this comment.
I think this GetShoots function could be optimized. I will explore the possibility of adding a new function that allows getting shoots assigned to a global account using the label selector.
MarekMichali
added
the
do-not-merge/hold
MarekMichali
force-pushed
the
use-multiple-bindings
branch
from
3311418 to
ba10d9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… number of clusters
Description
Changes proposed in this pull request:
Related issue(s)