Skip to content

replace legacy controller image with buildless in apply_test #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anoipm merged 3 commits into from
Apr 13, 2026
Merged

replace legacy controller image with buildless in apply_test #2461

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46b5a54
replace legacy controller image with buildless in apply_test
anoipm Apr 13, 2026
16e5917
Merge branch 'main' into remove-legacy-mode-apply-test
anoipm Apr 13, 2026
8e7c2e7
Merge branch 'main' into remove-legacy-mode-apply-test
anoipm Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions components/operator/internal/state/apply_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
)

const (
envName = "IMAGE_FUNCTION_CONTROLLER"
envName = "IMAGE_FUNCTION_BUILDLESS_CONTROLLER"
runtimeImageEnvName = "IMAGE_FUNCTION_RUNTIME_NODEJS24"
kymaFipsModeEnv = "KYMA_FIPS_MODE_ENABLED"
fipsVariantImageEnvKeySuffix = "_FIPS"
Expand Down Expand Up @@ -151,15 +151,15 @@ func TestUpdateImageIfOverride(t *testing.T) {
name: "Override image",
envKey: envName,
envs: map[string]string{envName: "newImage"},
bindUpdater: func(b *flags.Builder) flags.ImageReplace { return b.WithImageFunctionBuildfulController },
expectedKey: "function_buildful_controller",
bindUpdater: func(b *flags.Builder) flags.ImageReplace { return b.WithImageFunctionController },
expectedKey: "function_controller",
expectedValue: "newImage",
},
{
name: "Don't override image when empty env",
envKey: envName,
envs: map[string]string{},
bindUpdater: func(b *flags.Builder) flags.ImageReplace { return b.WithImageFunctionBuildfulController },
bindUpdater: func(b *flags.Builder) flags.ImageReplace { return b.WithImageFunctionController },
},
{
name: "Choose FIPS variant images when Fips mode enabled",
Expand Down
Loading