fix: support app start and value read until SDK 34 since SDK 28 despite no value update guarantee#426
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #401, closes #329, resolves #389, reactivating #231 which once fixed #225 by dealing with
NoSuchMethodErrorthrown fromgetActiveSubscriptionInfoListbut seems to have mistakenly been reverted since #387 which has started to throw the newNoSuchMethodExceptionuntil SDK 34.Supports another old
getActiveSubscriptionInfoListfunction signature which had been used until SDK 29.The
as?andemptyListfix the following bug asSubscriptionManagerhas also prevented since SDK 35, saying, "Beginning with Android SDK 35, this method will never return null":Fixes #420 (comment), closes #398 (comment), resolves #423 (comment), only about
NullPointerExceptionthrown fromgetSubscriptionCarrierNamewhich might return null in some cases according to its specification.Fixes #273, closes #320 (comment), resolving
NoClassDefFoundErrorthrown fromTelephonyFrameworkInitializeradded since SDK 30.We can bypass its
TelephonyServiceManagerwhose methods are just refactored results.Supports old
getActiveSubscriptionInfoForSimSlotIndexwhose function signature had been different from that of today until SDK 29, catchingNoSuchMethodError.Supports deprecated
getConfigForSubIdonNoSuchMethodErrorin place ofgetConfigForSubIdWithFeaturewhich had not been added until SDK 29Fixes the following
NullPointerExceptionthrown fromgetConfigForSubIdWithFeatureunlike its non-null implementation, by considering it nullable:Supports another function signature of
getConfigForSubIddeclared until SDK 28.You can download and test the built apk here but need to uninstall the previous release if any: https://github.com/yhkee0404/pixel-volte-patch/releases/tag/1.3.1_PR_426_430_431_432
안녕하세요 ㅎㅎ 처음 뵙겠습니다!