Fix hanging processes when warc download fails #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a
RequestExceptionoccurred while getting a WARC url, the sub-process running thedocument_generatorfunction would crash without yielding any result.The following logic
would thus never reach the expected count, preventing the loop from breaking, causing the main process to hang indefinitely.
This commit fixes the issue by:
get_responsecall in a try-except to catchRequestException, yielding a WarcResults with success=False in case of a RequestExceptionIt also improve the error reporting with some statistics about failed WARC and records.